Closed
Bug 1658895
Opened 5 years ago
Closed 5 years ago
We unnecessarily trace wrapper rooters in mark slices
Categories
(Core :: JavaScript: GC, enhancement, P1)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
We currently trace AutoGCRooters for wrappers in every mark slice and every sweep slice. These are the auto rooters used for CCWs that do not escape and allow us to skip the read barrier and avoid retaining all CCWs we examine during an incremental GC.
I don't think we need to do this in mark slices if we're not going to sweep anything in that slice. We only need to do this if we're potentially going to sweep, i.e. destroy the thing that the rooter is holding.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbc6deb2c405
Don't trace wrapper rooters in mark slices r=sfink
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•