Closed Bug 1658961 Opened 4 years ago Closed 3 years ago

Frequent frame dropping on https://www.tvnow.de when watching HD video

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

Split out from bug 1652516.

Here's a video from comment 15, but I'm afraid it doesn't play in HD: https://www.tvnow.de/shows/frauentausch-1668/2020-07/episode-454-vanessa-tauscht-mit-jana-257236

Here is a recent profile from Jones H who originally filed this bug.

New user profile w/o screenshots and w/ WebRender enabled as suggested: https://share.firefox.dev/3k34eoY

I'm putting this in the Graphics component because it looks like this is compositor jank.

@Sotaro: More video perf issues.

Severity: -- → S2
Flags: needinfo?(sotaro.ikeda.g)
Priority: -- → P3
Component: Graphics → Graphics: Layers
Flags: needinfo?(sotaro.ikeda.g)
Flags: needinfo?(sotaro.ikeda.g)
Component: Graphics: Layers → Graphics

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)

New user profile w/o screenshots and w/ WebRender enabled as suggested: https://share.firefox.dev/3k34eoY

:mconley, the profile has CompositorOGL stack. From it, WebRender should not be enabled on the profile. Does the problem happen also with WebRender? And is it a MacOS specific bug?

Flags: needinfo?(mconley)

(In reply to Sotaro Ikeda [:sotaro] from comment #2)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)

New user profile w/o screenshots and w/ WebRender enabled as suggested: https://share.firefox.dev/3k34eoY

:mconley, the profile has CompositorOGL stack. From it, WebRender should not be enabled on the profile. Does the problem happen also with WebRender? And is it a MacOS specific bug?

Sorry, a first profile of bug 1652516 uses WebRender.

Flags: needinfo?(mconley)

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Priority: P3 → --

:mconley, does the jank also happen with WebRender on nightly on MacOS?

Flags: needinfo?(mconley)

Actually Jonas is facing this problem, so forwarding the needinfo to him.

Flags: needinfo?(mconley) → needinfo?(jonas)

Are you asking for latest nightly? My profiles were done with and without WebRender using nightly from ~3 weeks ago, and I've experienced very low FPS on HD all the time.

Flags: needinfo?(jonas)

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)

Split out from bug 1652516.

Here's a video from comment 15, but I'm afraid it doesn't play in HD: https://www.tvnow.de/shows/frauentausch-1668/2020-07/episode-454-vanessa-tauscht-mit-jana-257236

It seems that the video could not be seen without account. Though we could see a sample video from the following.

Frame drop and HD issue seemed like a different problem. The HD issume might not be a graphics problem.

(In reply to Mike Conley (:mconley) (:⚙️) from comment #0)

New user profile w/o screenshots and w/ WebRender enabled as suggested: https://share.firefox.dev/3k34eoY

Content process always does a lot of rendering. It caused compositing more busy.

Flags: needinfo?(sotaro.ikeda.g)

Hi Mike,

Following up on this bug but I'm unable to reproduce the video as it seems it requires registration to Premium service.

Since this issue comes from bug 1652516 which is currently in active discussions, would it be OK to close this one?

Thanks,

Flags: needinfo?(mconley)

(In reply to Virginia Balducci from comment #10)

Since this issue comes from bug 1652516 which is currently in active discussions, would it be OK to close this one?

Why? This bug has been explicitly spun-off from bug 1652516 because it's a different issue. So no, we have to keep this bug open.

Flags: needinfo?(mconley)

Jonas, would you mind recording a new profile for such a high-resolution video? Recently a new Runnable feature was added, and it would be great to have that info. Also make sure to select Firefox Graphics setting from the profiler. Thank you.

Flags: needinfo?(jonas)

https://share.firefox.dev/3cG2yAc this is with latest nightly.

Note that I have a new machine now (M1 MacBook Pro), it works flawlessly with that machine and that Firefox version.

Flags: needinfo?(jonas)

It's good to hear that it works way better for you now with the new M1 machine. The downside is that we cannot verify it on an Intel machine in combination with MacOS 10.15 anymore.

Markus, based on all the investigations for MacOS and CoreAnimation the last days, is there anything you can see in the provided profile from comment 0? Otherwise it's a bit complicated to reproduce given that a premium account is needed for that streaming site to see HD content.

Flags: needinfo?(mstange.moz)

I can create a profile on the old Intel machine but it has macOS 11.2 now.

If you can please do it. Maybe it's more a hardware related issue, and might also happen with Big Sur.

Hi Jonas, have you had the time to already check it with the old MacBook?

Flags: needinfo?(jonas)

Here we go! https://share.firefox.dev/3s0SINO

It's still lagging terribly, but almost watchable in HD now!

Flags: needinfo?(jonas)

(In reply to Jonas H. from comment #18)

Here we go! https://share.firefox.dev/3s0SINO

It's still lagging terribly, but almost watchable in HD now!

Markus, would that also depend on bug 1690621? I see a good amount of those Runnables on the main thread.

Jonas, bug 1690621 has been fixed two weeks ago. Would you mind testing again with your old Macbook?

Flags: needinfo?(jonas)

I have a profile but was unable to upload it. Tried multiple times but there would always be an error (maybe upload server error?) at the very end of uploading. I also think it's too large to upload here. Any other ideas?

You could try to deselect screenshot, not include hidden threads. Maybe that already helps? Otherwise maybe you can share it via a file hoster like Dropbox etc?

Hey, that really worked out. So probably hit the upload size limit? (50 MiB?) Can't be sure because the error message just says "Uh oh something went wrong".

https://share.firefox.dev/3rQoldc

Performance/UX has improved a lot compared to the last time I profiled (https://bugzilla.mozilla.org/show_bug.cgi?id=1658961#c18). There are some frame drops left every now and then, so I'm likely going to use a different browser still.

Flags: needinfo?(jonas)

Note, I did some jumping around in the video starting at ~120s in the profile. That's where the increased network traffic comes from.

I had a look at the profile. So what I can see is:

  • The web content process takes 20% for handling setTimeout events, which is bug 1641673. Olli, I assume that the time spend in setInterval handler is similar to that bug?

  • The rendering seems to indeed require way lesser CPU nowadays. But it would be good to get some feedback from Markus here, if there is anything left.

Flags: needinfo?(bugs)

The page seems to be running setTimeout all the time. Most of them are very short. And probably because of those it is causing also
lots of JS garbage.

Flags: needinfo?(bugs)

if it's all about setTimeout what's remaining now maybe we should dupe it back to bug 1652516?

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #27)

if it's all about setTimeout what's remaining now maybe we should dupe it back to bug 1652516?

Olli, do you think it's fine to just dupe it now?

Flags: needinfo?(mstange.moz) → needinfo?(bugs)

Well, this was split from that. So if this is only about the page using too many timers, we could close this.

Flags: needinfo?(bugs)

Yes, it was split-off due to low FPS when watching HD videos on that portal. But as we have seen recently this specific problem is gone while the huge amount of setTimeout calls are still there. So maybe lets mark it as WFM instead.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.