Closed Bug 1659002 Opened 3 months ago Closed 2 months ago

Fix notifyObservers usage in Region.jsm

Categories

(Firefox :: Search, defect, P4)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: daleharvey, Assigned: aichi.p.chang)

Details

Attachments

(1 file, 1 obsolete file)

When I added the notifyObservers call I got the args wrong

https://searchfox.org/mozilla-central/source/toolkit/modules/Region.jsm#302

The region should be the subject of that call replacing the first param which is currently null (https://searchfox.org/mozilla-central/source/xpcom/ds/nsIObserverService.idl#62)

Should probably add a test to https://searchfox.org/mozilla-central/source/toolkit/modules/tests/xpcshell/test_Region.js to make sure it remains correct

Hello, I'd like to work on this if it's okay :)

Assignee: nobody → aichi.p.chang

Great! its assigned to you know

Depends on D87271

Attachment #9170385 - Attachment is obsolete: true
Attachment #9170372 - Attachment description: Bug 1659002 - add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey → Bug 1659002 - Fixed eslint complains, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey
Attachment #9170372 - Attachment description: Bug 1659002 - Fixed eslint complains, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey → Bug 1659002 - Fixed eslint complains,fixed typos, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey
Attachment #9170372 - Attachment description: Bug 1659002 - Fixed eslint complains,fixed typos, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey → Bug 1659002 - Fix passing region data to notifyObservers. r=daleharvey
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1308c79a573b
Fix passing region data to notifyObservers. r=daleharvey
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.