Closed
Bug 1659002
Opened 4 years ago
Closed 4 years ago
Fix notifyObservers usage in Region.jsm
Categories
(Firefox :: Search, defect, P4)
Firefox
Search
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: daleharvey, Assigned: aichi.p.chang)
Details
Attachments
(1 file, 1 obsolete file)
When I added the notifyObservers call I got the args wrong
https://searchfox.org/mozilla-central/source/toolkit/modules/Region.jsm#302
The region should be the subject of that call replacing the first param which is currently null (https://searchfox.org/mozilla-central/source/xpcom/ds/nsIObserverService.idl#62)
Should probably add a test to https://searchfox.org/mozilla-central/source/toolkit/modules/tests/xpcshell/test_Region.js to make sure it remains correct
|
Reporter | |
Updated•4 years ago
|
Assignee: nobody → aichi.p.chang
|
Assignee | |
Comment 3•4 years ago
|
||
|
||
Updated•4 years ago
|
Attachment #9170385 -
Attachment is obsolete: true
|
|
||
Updated•4 years ago
|
Attachment #9170372 -
Attachment description: Bug 1659002 - add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey → Bug 1659002 - Fixed eslint complains, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey
|
|
||
Updated•4 years ago
|
Attachment #9170372 -
Attachment description: Bug 1659002 - Fixed eslint complains, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey → Bug 1659002 - Fixed eslint complains,fixed typos, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey
|
|
||
Updated•4 years ago
|
Attachment #9170372 -
Attachment description: Bug 1659002 - Fixed eslint complains,fixed typos, add region as a nsISupports string to pass to notify observers in Region.jsm, add test in test_Region.js to test if the notification is fired with the correct region r=daleharvey → Bug 1659002 - Fix passing region data to notifyObservers. r=daleharvey
Pushed by dharvey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1308c79a573b Fix passing region data to notifyObservers. r=daleharvey
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•