Closed
Bug 1659051
Opened 5 years ago
Closed 5 years ago
emitStringFromCodeResult should handle failure path before discarding the stack
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
The failure path should be handled before discarding the stack. I don't think this can (currently) lead to any issues, but it's easy to trigger crashes when two AutoScratchRegister are added to BaselineCacheIRCompiler::emitStringFromCodeResult and then running it on 32-bit systems.
|
Assignee | |
Comment 1•5 years ago
|
||
The test case crashes without this patch when two AutoScratchRegister
are added to BaselineCacheIRCompiler::emitStringFromCodeResult().
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce9054fff73e
Take failure path before discarding the stack. r=jandem
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•