1659063 - Inconsistent rendering of svgs

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[David Bachmann]

Attachment: MiniTestMitIcons.svg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Safari/537.36 Edg/84.0.522.59

Steps to reproduce:

Open the attached svg in Firefox on some specific devices. It represents a menu tree.

The image contains several <svg> tags that contain <image> tags. Removing these seems to elimitate the bug.

Actual results:

Only the text of the first node and the rectangle in the tree is shown, none of the lines are visible.

The devices I could test that consistently produced the issue are Intel NUC6i5SYB with Intel Iris 540 graphics running Windows 10. (We have multiple of those in our office)

Expected results:

All texts in the svg should be visible, along with all lines.

This also actually happens in Firefox, just not on all devices. My PC with an Intel i3-4170 with Intel HD 4400 graphics running windows 10 renders this svg just fine. So does Chrome on both devices.

Comment 1

[David Bachmann]

Attachment: An example of the broken rendering

Comment 2

[David Bachmann]

Attachment: An example of the correct rendering

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Renders wrong with WebRender enabled, fine with WebRender disabled.

Comment 5

[David Bachmann]

That seems to be a correct diagnosis. If I set "gfx.webrender.enabled" to true, I can reproduce the error. If I set "gfx.webrender.force-disabled" to true on the maschine that has the issue, the bug disappears.

The NUC thing seems to have been coincidental.

Thank you for the quick response :)

Comment 6

[Darkspirit]

Thanks for the report!
mozregression --good 77 --bad 78 --pref gfx.webrender.all:true -a https://bug1659063.bmoattachments.org/attachment.cgi?id=9169981

7:28.10 INFO: Last good revision: e27a62f854b29efd5719040bb53227b65c3e954a
7:28.10 INFO: First bad revision: a86dcd6715c9e52fdd8e4a937b5e94ea2b9a5fcb
7:28.10 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e27a62f854b29efd5719040bb53227b65c3e954a&tochange=a86dcd6715c9e52fdd8e4a937b5e94ea2b9a5fcb

a86dcd6715c9e52fdd8e4a937b5e94ea2b9a5fcb Bert Peers — Bug 1555356 - Make images inside of SVGs active. r=aosmond

Comment 7

[Kris Taeleman (:ktaeleman)]

@Andrew: you were the reviewer of that change, could you take a look what needs to happen here?

Comment 8

[Robert Longson [:longsonr]]

bug 1684625 fixes this by preffing off the code path in bug 1555356. That fixes this bug and should prevent it returning as the reftests I've checked in should cover this case.

Comment 9

[Ciprian Georgiu, Desktop QA]

I managed to reproduce this bug by using the steps from comment 0, on an affected Nightly build 81.0a1 (20200814094524).

The issue is verified as fixed on the latest Beta build 86.0b5, across platforms: Win 10 x64, macOS 10.14 and Ubuntu 18.04 x64.