1659073 - Expose a new "RepostPrompt" PromptRequest type

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Needed for Fenix - https://github.com/mozilla-mobile/fenix/issues/9799 in the context of pull to refresh.

We need a sure way to know that upon dragging the throbber to refresh the page, event that successfully gets to Gecko, the reload operation is cancelled and so the throbber should not anymore wait the page to be reloaded.

I think just adding a new PromptRequest type for this kind of situations would be the simplest approach but of course there might be better solutions.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

So we did a bunch of the plumbing to make this possible in Bug 1629113. It should be a matter of adding insecureSubmitCheck to nsIPromptCollection, replace this code with InsecurePromptCollection (like this patch) and implement insecureSubmitCheck on desktop here (example here) and on mobile here (example here).

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Just to confirm, with those changes we would get some sort of a callback based on which we could trigger the action to hide the pull to refresh throbber in Fenix?

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

(In reply to Petru-Mugurel Lingurar [:petru] from comment #2)

Just to confirm, with those changes we would get some sort of a callback based on which we could trigger the action to hide the pull to refresh throbber in Fenix?

With the changes in Comment 1, you would get a onInsecureSubmitPrompt call instead of the generic onButtonPrompt or whatever you're getting today.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1659073 - Add confirmRepost to nsIPromptCollection.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1659073 - Implement confirmRepost on Mobile.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2702170d84c4
Add confirmRepost to nsIPromptCollection. r=pbz,smaug
https://hg.mozilla.org/integration/autoland/rev/de21d23f93cf
Implement confirmRepost on Mobile. r=owlish,snorp

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2702170d84c4
https://hg.mozilla.org/mozilla-central/rev/de21d23f93cf