Closed Bug 1659122 Opened 5 years ago Closed 5 years ago

Last used printer is not saved when printing from the new tab-modal UI.

Categories

(Core :: Printing: Setup, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: bobowen, Assigned: jwatt)

References

Details

(Whiteboard: [print2020_v81][fixed by bug 1653319])

I've only tested this on Windows.
If I print via the native dialog, it does seem to save the last used printer. Whether by flipping the tab-modal pref off or by the "Print using the system dialog..." link.

I also notice that we don't seems to be picking up the saved settings for a printer, when you switch in the Destination and we in fact overwrite at least some of the saved prefs using the previously selected printer's settings.
This may be an unrelated issue, if it is not intended.

Blocks: 133787
Severity: -- → S2
Whiteboard: [print2020]
Assignee: nobody → emilio

Stealing.

Assignee: emilio → jwatt

Oh, hold on. I was thinking my changes in bug 1653319 made this easy to fix now, but actually it should be fully fixed.

The reason that we weren't saving the settings was because of this line:

https://searchfox.org/mozilla-central/rev/27932d4e6ebd2f4b8519865dad864c72176e4e3b/layout/printing/nsPrintJob.cpp#865

As of the fix for bug 1653319, we're no longer setting nsIPrintSettings.printSilent in the frontend code, and so we should enter that code and save the settings.

(The intention behind setting printSilent on the settings objects from the frontend was only to stop the print dialog opening when the new UI's "Print" button was clicked during the early development of the UI. Instead the platform code now checks for the pref and avoids spinning the nested event loop to open dialog if it's set. Doing that was a pain prior to bug 1587459 since it wasn't possible to distinguish in DoCommonPrint between print-from-Print-button and print-from-"Print using system dialog"-link.)

Status: NEW → RESOLVED
Closed: 5 years ago
Priority: -- → P2
Resolution: --- → FIXED
Whiteboard: [print2020] → [print2020_v81][fixed by bug 1653319]
You need to log in before you can comment on or make changes to this bug.