1659126 - Entering search mode in one tab and switching to another tab without search mode causes the url to be de-emphasized, and sometimes with a fading out effect even when not needed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Itiel]

Attachment: Screenshot

STR:

1. Open a new tab, open any website
2. Open another new tab, type something and click the open tabs icon from the one-offs
3. Click the tab with the website opened earlier

AR:
The url is de-emphasized.

ER:
Just the domain part is emphasized.

Comment 1

[Drew Willcoxon :adw]

Thanks, Itiel. Looks like it has something to do with the search mode indicator being present in the tab you're switching from. I can reproduce this after entering any search mode and then switching to a tab that's not in search mode.

Comment 2

[Marco Bonardo [:mak]]

I can investigate this

Comment 3

[Marco Bonardo [:mak]]

I have restricted the problem to this attribute set in setSearchMode:

      this.document.l10n.setAttributes(
        this.inputField,
        UrlbarUtils.WEB_ENGINE_NAMES.has(engineName)
          ? "urlbar-placeholder-search-mode-web-2"
          : "urlbar-placeholder-search-mode-other-engine",
        { name: engineName }
      );

And of course the same for the local one-offs placeholder setting.
I'm still not sure what is the underlying reason, but it seems more related to the placeholder than the search mode chiclet.

Comment 4

[Marco Bonardo [:mak]]

I found this interesting comment from Emilio: https://bugzilla.mozilla.org/show_bug.cgi?id=1658302#c4

I contacted Emilio and Masayuki on Slack to see if there's something I may check there.

Comment 5

[Marco Bonardo [:mak]]

Moving the value formatting into a promiseDocumentFlushed call workarounds the problem, so it is effectively something related to layout not being ready when we start formatting.

Comment 6

[Marco Bonardo [:mak]]

Emilio will look at this on the platform side, feel free to steal the bug in case it's fixable there!

Comment 7

[Emilio Cobos Álvarez (:emilio)]

This seems basically bug 1658302. The patch I attached there should help.

Comment 8

[Marco Bonardo [:mak]]

I have verified that the patch in bug 1658302, applied on autoland does indeed solve this problem, so we can mark this as fixed once that is fixed.
Because that fix landed with a test, I don't think we need another test in the urlbar for it.

Comment 10

[Marco Bonardo [:mak]]

Fixed by bug 1658302.

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I verified this issue using 82.0a1 (2020-09-14) on macOS 10.13 and Windows 10 x64.
Adrian could you help me with Ubuntu verification?

Comment 12

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 82 beta 1 (with update2 prefs enabled) and latest Nightly 83.0a1 2020-09-21 under Ubuntu 18.04 64-bit.