1659158 - WebIDL's 'void' type is changing to 'undefined'

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task, P2)

Description

[Tab Atkins Jr.]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Safari/537.36

Steps to reproduce:

As part of efforts to finally add an 'undefined' type to WebIDL (so methods/etc don't have to generalize their type to 'any'), it was decided to actually add 'undefined' as the type name, and so the previous function return signature 'void' is being removed for redundancy.

See https://github.com/heycam/webidl/pull/906 for details on the change.

This change will be merged shortly; this bug is a heads-up to adjust your IDL parser (see the PR for the changes to the grammar; it's quite small). You may wish to have a transitional period where you recognize 'void' and 'undefined' as synonyms, as specifications are moved over to the new syntax.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1659158 - Switch WebIDL from void to undefined. r?edgar!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:peterv, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Peter Van der Beken [:peterv]]

This is blocked on figuring out the spec part (https://github.com/heycam/webidl/issues/962) and implementing the union support (which I have mostly done).

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1659158 - Replace IDL void type with undefined r=edgar,peterv

This does not add union support for undefined yet. Still, it should allow devs to copy-paste IDL from the spec without manually replacing undefined to void.

Comment 5

[Peter Van der Beken [:peterv]]

I don't think we should do this without the union support. I pushed my patches to try: https://treeherder.mozilla.org/jobs?repo=try&revision=8dabab23487a9aba857ac35b9dd9d07e7bcef2ef

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: Bug 1659158 - Support undefined in union. r?edgar!

Depends on D107108

Comment 7

[Peter Van der Beken [:peterv]]

Attachment: Diff of generated binding code

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Seems like this should be fairly close to landable, and would make people adding new code match the specs, which is nice...

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: Diff of generated binding code

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D144876	Bug 1659158 - Support undefined in union. r?edgar!	peterv	edgar: Inactive

:peterv, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a62d45d03cf
Switch WebIDL from void to undefined. r=edgar
https://hg.mozilla.org/integration/autoland/rev/d65760500d06
Support undefined in union. r=edgar

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8a62d45d03cf
https://hg.mozilla.org/mozilla-central/rev/d65760500d06