1659265 - Remove layout.css.offset-logical-properties.enabled.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

This was turned off in bug 1471838, so it's also about time to remove the code.

This involves removing the occurrences of the pref, including this line and fix the relevant tests that use the pref.

Comment 1

[shnmorimoto]

I would like to pick up this issue.
Should I just run ./mach mochitest for the test?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

No, ./mach mochitest will run all the tests, which would take forever on a single machine :)

Probably just building + a sanity check like ./mach mochitest layout/style/test/test_value_computation.html is enough.

Comment 3

[shnmorimoto]

Attachment: Bug 1659265 - remove layout.css.offset-logical-properties.enabled.

Comment 4

[shnmorimoto]

Thanks for replying!

I've confirmed that layout.css.offset-logical-properties.enabled is not exists except this line.

And the results of running ./mach mochitest layout/style/test/test_value_computation.html is below.

 0:56.19 TEST_END: Test OK. Subtests passed 41743/41796. Unexpected 0
 0:56.20 INFO TEST-START | Shutdown
 0:56.20 INFO Passed:  41743
 0:56.20 INFO Failed:  0
 0:56.20 INFO Todo:    53
 0:56.20 INFO Mode:    e10s
 0:56.20 INFO Slowest: 40178ms - /tests/layout/style/test/test_value_computation.html
 0:56.20 INFO SimpleTest FINISHED
 0:56.20 INFO TEST-INFO | Ran 1 Loops
 0:56.20 INFO SimpleTest FINISHED

I've created patch. Could you review?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Sure! For reference, you can tag me as a reviewer in the Phabricator UI, or you can append r=emilio to your commit message and it'd be automatically added by the submission tool.

Comment 6

[shnmorimoto]

Thanks a lot. I will do that next time.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b265dd4d6245
remove layout.css.offset-logical-properties.enabled. r=emilio

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b265dd4d6245