Closed Bug 1659265 Opened 3 years ago Closed 3 years ago

Remove layout.css.offset-logical-properties.enabled.


(Core :: CSS Parsing and Computation, defect)




81 Branch
Tracking Status
firefox81 --- fixed


(Reporter: emilio, Assigned: shnmorimoto, Mentored)


(Keywords: good-first-bug, Whiteboard: [lang=rust])


(1 file)

This was turned off in bug 1471838, so it's also about time to remove the code.

This involves removing the occurrences of the pref, including this line and fix the relevant tests that use the pref.

Mentor: emilio
Keywords: good-first-bug
Whiteboard: [lang=rust]
Assignee: emilio → nobody
Severity: -- → S4

I would like to pick up this issue.
Should I just run ./mach mochitest for the test?

No, ./mach mochitest will run all the tests, which would take forever on a single machine :)

Probably just building + a sanity check like ./mach mochitest layout/style/test/test_value_computation.html is enough.

Thanks for replying!

I've confirmed that layout.css.offset-logical-properties.enabled is not exists except this line.

And the results of running ./mach mochitest layout/style/test/test_value_computation.html is below.

 0:56.19 TEST_END: Test OK. Subtests passed 41743/41796. Unexpected 0
 0:56.20 INFO TEST-START | Shutdown
 0:56.20 INFO Passed:  41743
 0:56.20 INFO Failed:  0
 0:56.20 INFO Todo:    53
 0:56.20 INFO Mode:    e10s
 0:56.20 INFO Slowest: 40178ms - /tests/layout/style/test/test_value_computation.html
 0:56.20 INFO SimpleTest FINISHED
 0:56.20 INFO TEST-INFO | Ran 1 Loops
 0:56.20 INFO SimpleTest FINISHED

I've created patch. Could you review?

Sure! For reference, you can tag me as a reviewer in the Phabricator UI, or you can append r=emilio to your commit message and it'd be automatically added by the submission tool.

Assignee: nobody → shnmorimoto

Thanks a lot. I will do that next time.

Pushed by
remove layout.css.offset-logical-properties.enabled. r=emilio
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.