Misc code cleanup before implementing C++ Markers 2.0
Categories
(Core :: Gecko Profiler, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(4 files)
Some small changes before starting the full implementation of Markers 2.0.
|
Assignee | |
Comment 1•4 years ago
|
||
This patch makes it possible to serialize and deserialize std::basic_string's of different character types, not just std::string. This will be useful when dealing with char16_t from nsString and others.
We also expose the internal read-contents functions, to allow the user to read a sequence of characters of already-known length.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Instead of including all of BaseProfiler.h, we only need to declare the one function that we need in this header.
Depends on D87237
|
|
Assignee | |
Comment 3•4 years ago
|
||
It is just not needed here.
Depends on D87238
|
|
Assignee | |
Comment 4•4 years ago
|
||
I want to use PROFILER_MARKER in the new C++ marker APIs, so I'm renaming this single (recent) use to something else.
Depends on D87239
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95ce902890c1 Generic std::basic_string<CHAR> (de)serialization - r=gregtatum https://hg.mozilla.org/integration/autoland/rev/7a8f4f42225a Remove dependency on BaseProfiler.h from BaseProfilerDetail.h - r=gregtatum https://hg.mozilla.org/integration/autoland/rev/62ecfe9471fc Remove dependency on BaseProfiler.h from BaseProfilingCategory.h - r=gregtatum https://hg.mozilla.org/integration/autoland/rev/0a5e44820760 Rename AudioSink.cpp's PROFILER_MARKER to PROFILER_AUDIO_MARKER - r=gregtatum
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/95ce902890c1
https://hg.mozilla.org/mozilla-central/rev/7a8f4f42225a
https://hg.mozilla.org/mozilla-central/rev/62ecfe9471fc
https://hg.mozilla.org/mozilla-central/rev/0a5e44820760
Description
•