1659415 - Clickable area should be consistent for all the More settings options inside the new Print modal

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Attachment: Peek 2020-08-17 13-20.gif

Affected versions

• 81.0a1

Affected platforms

• Windows 10
• macOS 10.15
• Ubuntu 18.04

Steps to reproduce

1. Launch Firefox
2. Make sure the print UI via print.tab_modal.enabled is set on true
3. Hit CTRL + P
4. Extend the More settings dropdown
5. Select Scale
6. Click the right white area edge of the modal, next to Fit to page option
7. Attempt to select other options by keeping the same vertical alignment

Expected result

• The clickable area is limited and consistent for all the options (Scale and Options sections)

Actual result

• The clickable area is not consistent for all the options

Regression range

• Not a regression

Suggested severity

• I think that S4 is suitable for this issue

Comment 1

[Blake Winton (:bwinton) (:☕️)]

This might be fixed by the work Sam is doing, so cc-ing him to add it as a dependant bug if it is.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1659415 - 2nd column items don't need to fill available space in print UI. r?mstriemer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33b1476f952b
2nd column items don't need to fill available space in print UI. r=mstriemer

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9173527 [details]
Bug 1659415 - 2nd column items don't need to fill available space in print UI. r?mstriemer

Beta/Release Uplift Approval Request

• User impact if declined: Inconsistent clickable area on some labels in the new print UI
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment #0.
  Specifically, clicking in the whitespace to the right of the Scale and Backgrounds option labels should have no effect.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very minor (1-line) CSS-only patch in the print UI stylesheet, which itself is behind a pref.
• String changes made/needed: None

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/33b1476f952b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173527 [details]
Bug 1659415 - 2nd column items don't need to fill available space in print UI. r?mstriemer

Approved for 81.0b6.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/70466fa7fc28

Comment 8

[Anca Soncutean, Desktop QA]

Verified fixed with 82.0a1 (2020-09-04) and Fx 81.0b6 on Windows 10, macOS 10.14 and Ubuntu 18.04.