Closed Bug 1659430 Opened 5 years ago Closed 4 years ago

Categories

(Core :: Layout: Columns, defect, P5)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dholbert)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

This test is annotated as random [PASS, FAIL] on a bunch of configurations; really, it's probably random everywhere, and we just didn't cover all of the configurations.

Looking at the test, I think it needs reftest-wait. The reftest snapshot looks like it's been taken before the dynamic JS tweak has taken effect. reftest-wait would address this and hopefully make the test pass reliably, which would let us remove the .ini annotation file altogether.

This test has some JS that restyles an element, and the test implicitly expects
this JS to run before the screenshot is taken (otherwise the test fails).

However: before this patch, I don't think there's anything stopping the
test-harness from taking its screenshot earlier -- the screenshot can happen as
soon as the load event fires (and after any pending paints at that point are
flushed). This may be before the test's requestAnimationFrame-triggered JS has
been run.

This patch addresses this issue by adding 'reftest-wait', which explicitly
requires the test harness to delay its screenshot until after the restyle has
occurred.

Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af483daf2b28 Add "reftest-wait" to WPT increase-prev-sibling-height.html, to address intermittent failures. r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28330 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: