Closed Bug 1659452 Opened 5 months ago Closed 5 months ago

Restore basic function names in GDB for linux nightly builds

Categories

(Firefox Build System :: Task Configuration, defect)

defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox79 unaffected, firefox80 unaffected, firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- unaffected
firefox81 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fuzzblocker])

Attachments

(1 file)

Since bug 1647780 landed, Nightly builds don't show symbols anymore in GDB. Previously, function names were preserved and those are used in fuzzing when testing the JS shell on Linux32/64 debug/opt.

The upcoming patch restores the old behavior for these builds only.

Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e15d0c42b084
Restore basic function names in GDB. r=froydnj
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d270497c10a
Restore basic function names in GDB. r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Backed out for causing fuzzing build bustages on m-c

backout: https://hg.mozilla.org/integration/autoland/rev/1bbf6505e0214f3b4226af36c9833b33d39fdd69

failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedTaskRun=JE_F6MRFQd6m4rHqdxUBqQ.0&revision=069bb8bd2356b4d5738e1cec37bf561c24c0f923&searchStr=build

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313364388&repo=mozilla-central&lineNumber=1046

[task 2020-08-18T21:55:47.980Z] 21:55:47 INFO - checking whether cross compiling... no
[task 2020-08-18T21:55:48.082Z] 21:55:48 ERROR - Traceback (most recent call last):
[task 2020-08-18T21:55:48.082Z] 21:55:48 INFO - File "/builds/worker/checkouts/gecko/configure.py", line 183, in <module>
[task 2020-08-18T21:55:48.082Z] 21:55:48 INFO - sys.exit(main(sys.argv))
[task 2020-08-18T21:55:48.082Z] 21:55:48 INFO - File "/builds/worker/checkouts/gecko/configure.py", line 53, in main
[task 2020-08-18T21:55:48.082Z] 21:55:48 INFO - sandbox.run(os.path.join(os.path.dirname(file), 'moz.configure'))
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/init.py", line 457, in run
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - self._value_for(option)
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/init.py", line 547, in _value_for
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - return self._value_for_option(obj)
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 1018, in method_call
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - cache[args] = self.func(instance, *args)
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/init.py", line 615, in _value_for_option
[task 2020-08-18T21:55:48.083Z] 21:55:48 INFO - % option_string.split('=', 1)[0])
[task 2020-08-18T21:55:48.084Z] 21:55:48 INFO - mozbuild.configure.options.InvalidOptionError: STRIP_FLAGS is not available in this configuration
[task 2020-08-18T21:55:48.138Z] 21:55:48 INFO - *** Fix above errors and then restart with
[task 2020-08-18T21:55:48.139Z] 21:55:48 INFO - "./mach build"
[task 2020-08-18T21:55:48.139Z] 21:55:48 INFO - client.mk:111: recipe for target 'configure' failed
[task 2020-08-18T21:55:48.139Z] 21:55:48 INFO - make: *** [configure] Error 1
[task 2020-08-18T21:55:48.199Z] 21:55:48 ERROR - Return code: 2

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 81 Branch → ---
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14c0513e6bdd
Restore basic function names in GDB. r=froydnj
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e44357e87a8a
Backed out changeset 14c0513e6bdd as requested by decoder. CLOSED TREE
Attachment #9170389 - Attachment description: Bug 1659452 - Restore basic function names in GDB. r?froydnj → Bug 1659452 - Temporarily disable stripping for JS shell binaries. r?glandium
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbc6744b3ca2
Temporarily disable stripping for JS shell binaries. r=glandium
Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
See Also: → 1665013
Flags: needinfo?(choller)
You need to log in before you can comment on or make changes to this bug.