1659520 - Use explicit type arguments for `SyncedContext` field setters

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Nika Layzell [:nika] (ooo, ni? for response)]

It is currently possible to accidentally declare easy-to-misuse overloads of the generated setter methods from the synced context macros.

// The generated declarations look like
template <typename T>
nsresult SetFoo(T&& aValue);
// Making it possible to declare an buggy overload like
nsresult SetFoo(bool aFoo);

This can be bad, especially if the overload has different behaviour, as calls with types which are implicitly convertable to bool may actually call the generated method, rather than the explicit overload.

This has already happened once in the form of SetAllowContentRetargeting, which is both generated from the macro here: https://searchfox.org/mozilla-central/rev/fa7f47027917a186fb2052dee104cd06c21dd76f/docshell/base/BrowsingContext.h#119, and overloaded here: https://searchfox.org/mozilla-central/rev/fa7f47027917a186fb2052dee104cd06c21dd76f/docshell/base/BrowsingContext.h#465

Comment 1

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1659520 - Use explicit type arguments for `SyncedContext` field setters,

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a31a710e76e4
Use explicit type arguments for `SyncedContext` field setters, r=farre

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a31a710e76e4