1659523 - Fix Linux and Mac tests under remoted WebGL

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[David Parks [:handyman]]

Fix Linux and Mac tests that are busted under webgl.out-of-process=true. Windows tests already pass.

Comment 1

[David Parks [:handyman]]

Attachment: Bug 1659523: Free WebGL command shmem when actor is destroyed r=jgilbert!

Using the Shmem after our actor has lost IPC capability (say, because the other endpoint crashed) will cause the content process to also crash. ActorDestroy is where we detect that condition.

Comment 2

[David Parks [:handyman]]

Attachment: Bug 1659523: Make IPDL's reference to PWebGL actors "weak" r=jgilbert!,nika!

We want the IPDL actor to be freed when WebGL (not IPDL) no longer holds a strong reference to it. This pattern is handled by detecting when IPDL is the last remaining strong reference, at which point it calls Send__delete__ to begin to safely tear down the actors at both endpoints.

Depends on D87352

Comment 3

[David Parks [:handyman]]

Attachment: Bug 1659523: Avoid using stack variable as array parameter to GL in WebGL r=jgilbert!

Allocate a temporary buffer from the heap to appease GL.

Depends on D87353

Comment 4

[David Parks [:handyman]]

Attachment: Bug 1659523: Part 4 - Resolve issues with WebGL cycle collection r=jgilbert!

Weak pointers need to be cleared by the cycle collector to avoid dangling pointers. WeakPtr and WeakReference have special macros for this. std::weak_ptr, however, has a contract that does not permit clearing them through any means beyond normal weak_ptr use. So we switch to WeakPtr.

Depends on D87354

Comment 5

[David Parks [:handyman]]

Attachment: Bug 1659523: Wait for SpecialPowers to set pref before running WebGL tests r=jgilbert

Depends on D87355

Comment 6

[David Parks [:handyman]]

Attachment: Bug 1659523: Check CanSend() before calling Send() when allocating Shmems r=nika!

CanSend() is called (in ChannelSend()) by SendFoo() IPDL calls to prevent calling Send() on a dead actor but shmem creation uses a different code path to Send() -- one that does not use ChannelSend. This adds the guard to shmem allocation as well.

Depends on D87356

Comment 7

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Should bug 1654958 be dup'ed onto this? It looks like it's a subset of what these patches fix.

Comment 9

[David Parks [:handyman]]

(In reply to Jed Davis [:jld] ⟨⏰|UTC-6⟩ ⟦he/him⟧ from comment #7)

Should bug 1654958 be dup'ed onto this? It looks like it's a subset of what these patches fix.

Yes. Done.

Comment 10

[David Parks [:handyman]]

Attachment: Bug 1659523: Secure bool and enum serialization in remote WebGL r=jgilbert!

"Validate" bools to guarantee they always (de)serialize to proper values. Require that all enums use EnumSerializer or their own special handlers.

Depends on D87357

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aab07ad0abc
Free WebGL command shmem when actor is destroyed r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/6d5443ce7e95
Wait for SpecialPowers to set pref before running WebGL tests r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/cb77639a7d0e
Check CanSend() before calling Send() when allocating Shmems r=nika
https://hg.mozilla.org/integration/autoland/rev/2c9d59a24ce8
Secure bool and enum serialization in remote WebGL r=jgilbert

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8aab07ad0abc
https://hg.mozilla.org/mozilla-central/rev/6d5443ce7e95
https://hg.mozilla.org/mozilla-central/rev/cb77639a7d0e
https://hg.mozilla.org/mozilla-central/rev/2c9d59a24ce8