1659527 - Bad scaling and clipping of Save to PDF output [was: Erratic glyph spacing in Save As PDF output] on Windows

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Jonathan Kew [:jfkthame]]

Attachment: PDF created using Save As PDF on Windows 10

Looking at a PDF generated via Save As PDF on Windows, I'm seeing much inferior glyph spacing (some glyphs too crowded, others with gaps between) compared to the same document saved via Microsoft Print to PDF.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Same document saved via Microsoft Print to PDF

Comment 2

[Jonathan Kew [:jfkthame]]

FWIW, I tried the same page on macOS, and the Save As PDF output looks much better there.

Comment 3

[Jonathan Watt [:jwatt]]

Jonathan, how does this relate to bug 1662820?

Comment 4

[Jonathan Kew [:jfkthame]]

Hmm, sounds like it may be the same thing. Leaving needinfo until I re-test this....

Comment 5

[Jonathan Kew [:jfkthame]]

Trying to reproduce this, I'm now getting incorrectly scaled PDF output (looks fine in Preview but is oversized and clipped in the output). Most likely a regression from bug 1662820, I guess. :(

Comment 6

[Jonathan Watt [:jwatt]]

Ugh, that got uplifted to beta 81. Presumably the output with print.tab_modal.enabled set to false has also been broken?

Comment 7

[Jonathan Kew [:jfkthame]]

No, this only affects Save to PDF output, which isn't exposed as a destination via the old UI. So AFAICS that's not an issue.

Comment 8

[Jonathan Watt [:jwatt]]

It is exposed via the Web Extensions API. We may have broken Save to PDF for dw-dev, for example.

Comment 9

[Jonathan Kew [:jfkthame]]

Yes, I can confirm that Save As PDF from Print Edit WE is broken. I will test both a backout and a possible fix shortly (once my windows build is ready).

Comment 10

[Jonathan Kew [:jfkthame]]

Confirmed that backing out bug 1662820 fixes the bad scaling of Save to PDF output (but reintroduces the bad glyph spacing, as seen both in preview and the actual PDF output).

The real fix is that we also need to update nsDeviceContextSpecWin::GetPrintingScale to reflect the DPI value we're using. Patch coming after one more re-test locally...

Comment 11

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1659527 - Correct scaling for Save to PDF output on Windows to reflect DPI setting. r=jwatt

Comment 12

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1659527 - [for beta-81] Back out m-c changeset c7c18b456034 (bug 1662820) for regressing scaling in Save as PDF output. r=jwatt

Comment 13

[Jonathan Watt [:jwatt]]

Comment on attachment 9174673 [details]
Bug 1659527 - [for beta-81] Back out m-c changeset c7c18b456034 (bug 1662820) for regressing scaling in Save as PDF output. r=jwatt

Beta/Release Uplift Approval Request

• User impact if declined: Extensions that provide save-to-pdf functionality will create broken and clipped PDFs on Windows.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Backout. Reverts us to the previous code.
• String changes made/needed:

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ebc35a7e152
Correct scaling for Save to PDF output on Windows to reflect DPI setting. r=jwatt,emilio

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9174673 [details]
Bug 1659527 - [for beta-81] Back out m-c changeset c7c18b456034 (bug 1662820) for regressing scaling in Save as PDF output. r=jwatt

Approved for 81.0b9.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f57d81054b78

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5ebc35a7e152