1659551 - Implement caching for nsPrinterBase::CreateDefaultSettings

Status: RESOLVED FIXED

(Core :: Printing: Setup, task, P2)

Description

[Erik Nordin [:nordzilla]]

The nsPrinterBase::CreateDefaultSettings() function needs to resolve a promise with a new print settings object for each time that it's called.

Currently, this function will spawn a new background task and initialize a default print settings object with each function call.

We should improve the performance for the case of multiple calls by caching the first-created print settings object and resolving all subsequent promises by cloning the already-initialized, cached settings.

This way we won't be spawning multiple background tasks if CreateDefaultSettings() is invoked multiple times.

Comment 1

[Jonathan Watt [:jwatt]]

We probably don't need this for the inital release, so bumping to v82 (although if we get to it for v81 that's great).

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1659551 - Cache PrintSettingsInitializer r=jwatt,emilio

Adds caching for each nsPrinterBase's PrintSettingsInitializer so that
subsequent calls don't need to spawn a background task to retrieve it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d781be7a1d
Cache PrintSettingsInitializer r=jwatt,emilio

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c4d781be7a1d