1659589 - Get rid of a dependant of stylesheet actor from StyleEditor (to resource based)

Status: RESOLVED FIXED

(DevTools :: Style Editor, task)

Description

[Daisuke Akatsuka (:daisuke)]

Now, we watch/call stylesheet actor directly in StyleEditor.
However, in order to implement stylesheet watcher in the server-side, to get rid of a dependant of stylesheet actor is the desired way.
Instead, we change StyleEditor to resource-based.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Handle importing stylesheet from file using resource watcher mechanism to keep consistency.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Get style-applied event via resource watcher.

Depends on D87040

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Get property-change event via resource watcher.

Depends on D87041

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Get media-rules-changed event via resource watcher.

Depends on D87042

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Implement toggleDisabled in stylesheets actor.

Depends on D87043

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Implement getText in stylesheets actor.

Depends on D87044

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Implement getMediaRules in stylesheets actor.

Depends on D87045

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Implement update method in stylesheets actor.

Depends on D87046

Comment 9

[Marco Mucci [:MarcoM]]

Hello Daisuke. Should I add this bug as an MVP for Fission M2?

Comment 10

[Daisuke Akatsuka (:daisuke)]

Hello Marco! I think so!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a55dbee660a
Handle importing stylesheet from file using resource watcher mechanism to keep consistency. r=ochameau,devtools-backward-compat-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/5d2a954c65cc
Get style-applied event via resource watcher. r=ochameau,bomsy
https://hg.mozilla.org/integration/autoland/rev/b98fe620038d
Get property-change event via resource watcher. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/5ce60ce82c52
Get media-rules-changed event via resource watcher. r=ochameau

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9a55dbee660a
https://hg.mozilla.org/mozilla-central/rev/5d2a954c65cc
https://hg.mozilla.org/mozilla-central/rev/b98fe620038d
https://hg.mozilla.org/mozilla-central/rev/5ce60ce82c52

Comment 13

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1659589: Remove error event listener that set to stylesheet actor.

Depends on D87047

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc075afd9fdf
Implement toggleDisabled in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/e8258610951f
Implement getText in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/ad6708adb4cc
Implement update method in stylesheets actor. r=ochameau,devtools-backward-compat-reviewers
https://hg.mozilla.org/integration/autoland/rev/e1242e04253e
Remove error event listener that set to stylesheet actor. r=ochameau

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bc075afd9fdf
https://hg.mozilla.org/mozilla-central/rev/e8258610951f
https://hg.mozilla.org/mozilla-central/rev/ad6708adb4cc
https://hg.mozilla.org/mozilla-central/rev/e1242e04253e