1659599 - [WEBHOOKS] Implement authentication token in Webhooks

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[Lisset Cuevas]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Comment 1

[David Lawrence [:dkl]]

Work on this as the last item if time allowed. Talked with manager and this feature is not as critical as others.

Comment 2

[Lisset Cuevas]

(In reply to David Lawrence [:dkl] from comment #1)

Work on this as the last item if time allowed. Talked with manager and this feature is not as critical as others.

Ok, don't worry, I'd like to continue contributing to the project now that the intership ended :)

And about this, Should it be a parameter in the body or something in the header as the spark_api_key in the Spark Connector?

Comment 3

[David Lawrence [:dkl]]

(In reply to Lisset Cuevas from comment #2)

(In reply to David Lawrence [:dkl] from comment #1)

Work on this as the last item if time allowed. Talked with manager and this feature is not as critical as others.

Ok, don't worry, I'd like to continue contributing to the project now that the intership ended :)

And about this, Should it be a parameter in the body or something in the header as the spark_api_key in the Spark Connector?

IMO it should always be part of the header and never in the body or the query string. So for our case, we would new two fields
for the user to configure in the webhook. A field that is the actual header that will be included. In the case of BMOs API we accept
a header called X-Bugzilla-API-Key for example. And we need a second config field called key or something similar that is the
actual key or token to be passed. If either of those two fields are left blank, we just send the POST to the URL without the header
included as an anonymous client.

dkl

Comment 4

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 5

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 6

[David Lawrence [:dkl]]

Merged to master.
https://github.com/mozilla-bteam/bmo/commit/35fc683230ac7e042d27d9d93451c21f392a7294

Comment 7

[David Lawrence [:dkl]]

Reopening as need to do a schema only push first.

Comment 8

[David Lawrence [:dkl]]

Original commit reverted. Schema changes merged to master
https://github.com/mozilla-bteam/bmo/commit/fe22350a10856fa30a6e23744da5931513002606

Comment 9

[David Lawrence [:dkl]]

All merged and deployed live.
https://github.com/mozilla-bteam/bmo/commit/f8c98f3b3987bf45ec4020914ba1410547238326