Closed Bug 1659603 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25060 - [AspectRatio] Add tests for cross size in flexbox

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25060 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25060
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

[AspectRatio] Add tests for cross size in flexbox

This exposed a bug where we don't correctly compute the cross
size in a column flexbox with aspect-ratio.

R=ikilpatrick@chromium.org

Bug: 1045668,1117279
Change-Id: Ic823ed349e2caf061834e116d5958832745cd63a

Reviewed-on: https://chromium-review.googlesource.com/2358827
WPT-Export-Revision: 6b6dc2bb75bd0e29a009f115a8faf53b5ba02929

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

PASS: 2
FAIL: 2

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/flex-aspect-ratio-011.tentative.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-sizing/aspect-ratio/flex-aspect-ratio-014.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/flex-aspect-ratio-012.tentative.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-sizing/aspect-ratio/flex-aspect-ratio-013.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1b8dff746ec [wpt PR 25060] - [AspectRatio] Add tests for cross size in flexbox, a=testonly https://hg.mozilla.org/integration/autoland/rev/5252e6638ee2 [wpt PR 25060] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d1b8dff746ec
https://hg.mozilla.org/mozilla-central/rev/5252e6638ee2

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.