1659642 - APZUtils cleanups

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

It has long annoyed me that we don't have a place to put definitions that:

1. Can be used by both APZCTreeManager::SampleForWebRender and AsyncCompositionManager (two places that are often modified in tandem)
2. Does not involve adding a new file
3. Does not involve recompiling the world

In this bug I will make APZUtils.h into such a place.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1659642 - Move ExpectedGeckoMetrics to its own file. r=kats

It's only used in AsyncPanZoomController.{h,cpp}.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1659642 - Move IntervalOverlap() to AsyncCompositionManager.cpp. r=kats

It's the only place where it's used.

Depends on D87390

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1659642 - Split out a new file APZPublicUtils.h from APZUtils.h. r=kats

By moving the few things that need to be exposed to other components
to APZPublicUtils.h, APZUtils.h becomes much less widely included
(and thus changing it triggers a quicker recompile) while retaining
most of its utilities.

Depends on D87402

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1659642 - Move AsyncTransform from AsyncCompositionManager.h to APZUtils.h. r=kats

AsyncCompositionManager is a Layers-only component, and a bunch of
APZ code common to Layers and WR was including it for this one
utility.

Depends on D87404

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1659642 - Move ComputeFixedMarginsOffset() to APZUtils.h. r=kats

This removes the dependency edge from APZCTreeManager to
AsyncCompositionManager.

Depends on D87405

Comment 6

[Botond Ballo [:botond]]

The third patch reduces the rebuild time of a change to APZUtils.h by about an order of magnitude.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b9401717015
Move ExpectedGeckoMetrics to its own file. r=kats
https://hg.mozilla.org/integration/autoland/rev/e94f7683b786
Move IntervalOverlap() to AsyncCompositionManager.cpp. r=kats
https://hg.mozilla.org/integration/autoland/rev/b107b889c95a
Split out a new file APZPublicUtils.h from APZUtils.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/a9bb5ae7ddb3
Move AsyncTransform from AsyncCompositionManager.h to APZUtils.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/f24a0b762070
Move ComputeFixedMarginsOffset() to APZUtils.h. r=kats

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1659642 - Fix Android unified build bustage. r=tnikkel,hiro,mattwoodrow

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd8f35c51723
Fix Android unified build bustage. r=hiro

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1b9401717015
https://hg.mozilla.org/mozilla-central/rev/e94f7683b786
https://hg.mozilla.org/mozilla-central/rev/b107b889c95a
https://hg.mozilla.org/mozilla-central/rev/a9bb5ae7ddb3
https://hg.mozilla.org/mozilla-central/rev/f24a0b762070
https://hg.mozilla.org/mozilla-central/rev/cd8f35c51723