APZUtils cleanups
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
Details
Attachments
(6 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
It has long annoyed me that we don't have a place to put definitions that:
- Can be used by both
APZCTreeManager::SampleForWebRender
andAsyncCompositionManager
(two places that are often modified in tandem) - Does not involve adding a new file
- Does not involve recompiling the world
In this bug I will make APZUtils.h into such a place.
Assignee | ||
Comment 1•4 years ago
|
||
It's only used in AsyncPanZoomController.{h,cpp}.
Assignee | ||
Comment 2•4 years ago
|
||
It's the only place where it's used.
Depends on D87390
Assignee | ||
Comment 3•4 years ago
|
||
By moving the few things that need to be exposed to other components
to APZPublicUtils.h, APZUtils.h becomes much less widely included
(and thus changing it triggers a quicker recompile) while retaining
most of its utilities.
Depends on D87402
Assignee | ||
Comment 4•4 years ago
|
||
AsyncCompositionManager is a Layers-only component, and a bunch of
APZ code common to Layers and WR was including it for this one
utility.
Depends on D87404
Assignee | ||
Comment 5•4 years ago
|
||
This removes the dependency edge from APZCTreeManager to
AsyncCompositionManager.
Depends on D87405
Assignee | ||
Comment 6•4 years ago
|
||
The third patch reduces the rebuild time of a change to APZUtils.h by about an order of magnitude.
Updated•4 years ago
|
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b9401717015 Move ExpectedGeckoMetrics to its own file. r=kats https://hg.mozilla.org/integration/autoland/rev/e94f7683b786 Move IntervalOverlap() to AsyncCompositionManager.cpp. r=kats https://hg.mozilla.org/integration/autoland/rev/b107b889c95a Split out a new file APZPublicUtils.h from APZUtils.h. r=kats https://hg.mozilla.org/integration/autoland/rev/a9bb5ae7ddb3 Move AsyncTransform from AsyncCompositionManager.h to APZUtils.h. r=kats https://hg.mozilla.org/integration/autoland/rev/f24a0b762070 Move ComputeFixedMarginsOffset() to APZUtils.h. r=kats
Assignee | ||
Comment 8•4 years ago
|
||
Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd8f35c51723 Fix Android unified build bustage. r=hiro
Comment 10•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b9401717015
https://hg.mozilla.org/mozilla-central/rev/e94f7683b786
https://hg.mozilla.org/mozilla-central/rev/b107b889c95a
https://hg.mozilla.org/mozilla-central/rev/a9bb5ae7ddb3
https://hg.mozilla.org/mozilla-central/rev/f24a0b762070
https://hg.mozilla.org/mozilla-central/rev/cd8f35c51723
Description
•