Closed Bug 1659642 Opened 4 years ago Closed 4 years ago

APZUtils cleanups

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: botond, Assigned: botond)

Details

Attachments

(6 files)

It has long annoyed me that we don't have a place to put definitions that:

  1. Can be used by both APZCTreeManager::SampleForWebRender and AsyncCompositionManager (two places that are often modified in tandem)
  2. Does not involve adding a new file
  3. Does not involve recompiling the world

In this bug I will make APZUtils.h into such a place.

It's only used in AsyncPanZoomController.{h,cpp}.

It's the only place where it's used.

Depends on D87390

By moving the few things that need to be exposed to other components
to APZPublicUtils.h, APZUtils.h becomes much less widely included
(and thus changing it triggers a quicker recompile) while retaining
most of its utilities.

Depends on D87402

AsyncCompositionManager is a Layers-only component, and a bunch of
APZ code common to Layers and WR was including it for this one
utility.

Depends on D87404

This removes the dependency edge from APZCTreeManager to
AsyncCompositionManager.

Depends on D87405

The third patch reduces the rebuild time of a change to APZUtils.h by about an order of magnitude.

Attachment #9170582 - Attachment description: Bug 1659642 - Move ExpectedGeckoMetrics to AsyncPanZoomController.h r=kats → Bug 1659642 - Move ExpectedGeckoMetrics to its own file. r=kats
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b9401717015
Move ExpectedGeckoMetrics to its own file. r=kats
https://hg.mozilla.org/integration/autoland/rev/e94f7683b786
Move IntervalOverlap() to AsyncCompositionManager.cpp. r=kats
https://hg.mozilla.org/integration/autoland/rev/b107b889c95a
Split out a new file APZPublicUtils.h from APZUtils.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/a9bb5ae7ddb3
Move AsyncTransform from AsyncCompositionManager.h to APZUtils.h. r=kats
https://hg.mozilla.org/integration/autoland/rev/f24a0b762070
Move ComputeFixedMarginsOffset() to APZUtils.h. r=kats
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd8f35c51723
Fix Android unified build bustage. r=hiro
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: