Closed Bug 1659667 Opened 3 months ago Closed 3 months ago

Fix Wasm jit-tests expecting specific non-canonical NaN values

Categories

(Core :: Javascript: WebAssembly, task, P3)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: jandem, Assigned: lth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

On Apple ARM64 hardware we fail these two jit-tests:

These tests are checking for particular bit patterns for operations involving non-canonical NaNs. We get a different NaN value on Apple CPUs and that's fine because the Wasm spec doesn't specify all NaN bits, so we just need to fix the tests.

Assignee: nobody → lhansen
Status: NEW → ASSIGNED

Candidate: https://phabricator.services.mozilla.com/D87455. Jan, can you see if that resolves the problem on the device?

Flags: needinfo?(jdemooij)

These test cases expected specific payloads for some NaN results but
the wasm spec does not guarantee that, and some implementations of
some architectures will not return the same payloads as x64. So
adjust the tests.

(In reply to Lars T Hansen [:lth] from comment #1)

Candidate: https://phabricator.services.mozilla.com/D87455. Jan, can you see if that resolves the problem on the device?

It does!

% ./mach jit-test nan-semantics
[5|0|0|0] 100% ======================================================>| 
PASSED ALL

% ./mach jit-test conversion.js
[5|0|0|0] 100% ======================================================>| 
PASSED ALL

% ./mach jit-test
[8110|   0|   0|   0] 100% ==========================================>| 
PASSED ALL
Flags: needinfo?(jdemooij)
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd8b53cf8058
expect less specific NaN values. r=bbouvier
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.