1659667 - Fix Wasm jit-tests expecting specific non-canonical NaN values

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Jan de Mooij [:jandem]]

On Apple ARM64 hardware we fail these two jit-tests:

• wasm/conversion.js
• wasm/nan-semantics.js

These tests are checking for particular bit patterns for operations involving non-canonical NaNs. We get a different NaN value on Apple CPUs and that's fine because the Wasm spec doesn't specify all NaN bits, so we just need to fix the tests.

Comment 1

[Lars T Hansen [:lth]]

Candidate: https://phabricator.services.mozilla.com/D87455. Jan, can you see if that resolves the problem on the device?

Comment 2

[Lars T Hansen [:lth]]

Attachment: Bug 1659667 - expect less specific NaN values.

These test cases expected specific payloads for some NaN results but
the wasm spec does not guarantee that, and some implementations of
some architectures will not return the same payloads as x64. So
adjust the tests.

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Lars T Hansen [:lth] from comment #1)

Candidate: https://phabricator.services.mozilla.com/D87455. Jan, can you see if that resolves the problem on the device?

It does!

% ./mach jit-test nan-semantics
[5|0|0|0] 100% ======================================================>| 
PASSED ALL

% ./mach jit-test conversion.js
[5|0|0|0] 100% ======================================================>| 
PASSED ALL

% ./mach jit-test
[8110|   0|   0|   0] 100% ==========================================>| 
PASSED ALL

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd8b53cf8058
expect less specific NaN values. r=bbouvier

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bd8b53cf8058