Closed Bug 1659668 Opened 5 months ago Closed 5 months ago

Make sure the children array is big enough when adding a child using ReplaceElementAt in SessionHistoryEntry::AddChild

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Fission Milestone M6b
Tracking Status
firefox81 --- fixed

People

(Reporter: peterv, Assigned: peterv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The old code used an nsCOMArray, which ensures the length is big enough when you call ReplaceObjectAt, the new code uses nsTArray which doesn't do that. So the caller needs to do it.

Summary: Make sure the children array is big enough when adding a child in SessionHistoryEntry::AddChild → Make sure the children array is big enough when adding a child using ReplaceElementAt in SessionHistoryEntry::AddChild
Severity: -- → S3
Priority: -- → P2
Pushed by pvanderbeken@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53e8f4f05b5f
Make sure the children array is big enough when adding a child using ReplaceElementAt in SessionHistoryEntry::AddChild. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.