1659674 - Change BulkWrite to return mozilla::Result

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Simon Giesecke [:sg] [he/him]]

As the documentation says, mozilla::Result wasn't originally used for BulkWrite because it didn't support move-only success types at that time. Now it does, so the signature should be changed to get rid of the output parameter/return value duality.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1659674 - Change BulkWrite to return mozilla::Result. r=#xpcom-reviewers

Depends on D87413

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0327b662a05f
Change BulkWrite to return mozilla::Result. r=froydnj

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0327b662a05f

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7045c8e4fa99
Backed out changeset 0327b662a05f for nsStorageStream related central bustage CLOSED TREE

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 0327b662a05f (bug 1659674) for nsStorageStream related central bustage.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&collapsedPushes=719443%2C719327%2C719506%2C726551%2C726928%2C729538%2C748815%2C748704%2C748957%2C750516%2C750017%2C749744&group_state=expanded&selectedTaskRun=J61LoOuxQFeFQ279ocliwQ.0&searchStr=linux%2Cx64%2Copt%2Cbuild-linux64-base-toolchains%2Fopt%2Cbb&fromchange=b0888d07df690ed43df31a2b013d12464b183a30

Backout link: https://hg.mozilla.org/integration/autoland/rev/7045c8e4fa99812d0ebcbe21e5b9c4cf08987668

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313483417&repo=mozilla-central&lineNumber=45379

[task 2020-08-19T22:03:39.200Z] 22:03:39     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/io'
[task 2020-08-19T22:03:39.201Z] 22:03:39     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/gcc/bin/g++ -std=gnu++17 -o Unified_cpp_xpcom_io1.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/xpcom/io -I/builds/worker/workspace/obj-build/xpcom/io -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/xpcom -I/builds/worker/checkouts/gecko/xpcom/build -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-psabi -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fno-omit-frame-pointer -funwind-tables -Werror  -MD -MP -MF .deps/Unified_cpp_xpcom_io1.o.pp   Unified_cpp_xpcom_io1.cpp
[task 2020-08-19T22:03:39.201Z] 22:03:39     INFO -  In file included from Unified_cpp_xpcom_io1.cpp:92:0:
[task 2020-08-19T22:03:39.201Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp: In instantiation of 'void nsStorageInputStream::SerializeInternal(mozilla::ipc::InputStreamParams&, bool, uint32_t, uint32_t*, M*) [with M = mozilla::ipc::ParentToChildStreamActorManager; uint32_t = unsigned int]':
[task 2020-08-19T22:03:39.201Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:557:74:   required from here
[task 2020-08-19T22:03:39.202Z] 22:03:39    ERROR -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:576:12: error: variable 'rv' set but not used [-Werror=unused-but-set-variable]
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -     nsresult rv = Available(&remaining);
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -              ^~
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp: In instantiation of 'void nsStorageInputStream::SerializeInternal(mozilla::ipc::InputStreamParams&, bool, uint32_t, uint32_t*, M*) [with M = mozilla::ipc::ChildToParentStreamActorManager; uint32_t = unsigned int]':
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:564:74:   required from here
[task 2020-08-19T22:03:39.202Z] 22:03:39    ERROR -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:576:12: error: variable 'rv' set but not used [-Werror=unused-but-set-variable]
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp: In member function 'void nsStorageInputStream::SerializeInternal(mozilla::ipc::InputStreamParams&, bool, uint32_t, uint32_t*, M*) [with M = mozilla::ipc::ParentToChildStreamActorManager]':
[task 2020-08-19T22:03:39.202Z] 22:03:39  WARNING -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:516:14: warning: 'offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -     return Seek(pos);
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -            ~~~~^~~~~
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:588:11: note: 'offset' was declared here
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -     int64_t offset;
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -             ^~~~~~
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp: In member function 'void nsStorageInputStream::SerializeInternal(mozilla::ipc::InputStreamParams&, bool, uint32_t, uint32_t*, M*) [with M = mozilla::ipc::ChildToParentStreamActorManager]':
[task 2020-08-19T22:03:39.202Z] 22:03:39  WARNING -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:516:14: warning: 'offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -     return Seek(pos);
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -            ~~~~^~~~~
[task 2020-08-19T22:03:39.202Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/xpcom/io/nsStorageStream.cpp:588:11: note: 'offset' was declared here
[task 2020-08-19T22:03:39.203Z] 22:03:39     INFO -     int64_t offset;
[task 2020-08-19T22:03:39.203Z] 22:03:39     INFO -             ^~~~~~
[task 2020-08-19T22:03:39.203Z] 22:03:39     INFO -  cc1plus: all warnings being treated as errors
[task 2020-08-19T22:03:39.203Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:723: recipe for target 'Unified_cpp_xpcom_io1.o' failed
[task 2020-08-19T22:03:39.203Z] 22:03:39    ERROR -  make[4]: *** [Unified_cpp_xpcom_io1.o] Error 1
[task 2020-08-19T22:03:39.203Z] 22:03:39     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/xpcom/io'
[task 2020-08-19T22:03:39.204Z] 22:03:39     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:72: recipe for target 'xpcom/io/target-objects' failed
[task 2020-08-19T22:03:39.204Z] 22:03:39    ERROR -  make[3]: *** [xpcom/io/target-objects] Error 2
[task 2020-08-19T22:03:39.205Z] 22:03:39     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/7045c8e4fa99

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c04b7dc42231
Change BulkWrite to return mozilla::Result. r=froydnj

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c04b7dc42231

Comment 9

[Simon Giesecke [:sg] [he/him]]

Fixed gcc base toolchain build bustage and successfully re-landed.