Closed Bug 1659805 Opened 5 months ago Closed 5 months ago

Change SearchTestUtils to not use NetUtil, and to not require an argument to useMockIdleService

Categories

(Firefox :: Search, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED
81 Branch
Iteration:
81.2 - Aug 10 - Aug 23
Tracking Status
firefox81 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

I'd like to do a couple of minor changes to SearchTestUtils.jsm:

  • Drop the use of NetUtil.newChannel for reading engines.json files - fetch is just as good and simpler (we possibly needed it before for reading utf-8 engine names, but the new configuration doesn't need that).
  • Drop the registerCleanupFunction parameter to useMockIdleService. We can just use init() instead to define the function.

The latter one I want to use in a mochitest, so having that made simpler would be useful.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99e96116733a
Change SearchTestUtils to not use NetUtil, and to not require an argument to useMockIdleService. r=daleharvey
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.