1659805 - Change SearchTestUtils to not use NetUtil, and to not require an argument to useMockIdleService

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

I'd like to do a couple of minor changes to SearchTestUtils.jsm:

• Drop the use of NetUtil.newChannel for reading engines.json files - fetch is just as good and simpler (we possibly needed it before for reading utf-8 engine names, but the new configuration doesn't need that).
• Drop the registerCleanupFunction parameter to useMockIdleService. We can just use init() instead to define the function.

The latter one I want to use in a mochitest, so having that made simpler would be useful.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1659805 - Change SearchTestUtils to not use NetUtil, and to not require an argument to useMockIdleService. r?daleharvey!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e96116733a
Change SearchTestUtils to not use NetUtil, and to not require an argument to useMockIdleService. r=daleharvey

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/99e96116733a