Closed Bug 1659885 Opened 1 month ago Closed 1 month ago

Move shadow structure definitions to js/public/shadow

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(8 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Most of these are in jsfriendapi.h right now, which means if you touch that file, you rebuild the world. On the other hand, defining them in sufficiently small separate headers should be able to reduce dependency on jsfriendapi.h. (Or it should be able to do so once the other dependencies in jsfriendapi.h on these shadow structures are moved to separate, smaller headers.)

Nothing terribly interesting here, just Mercurial copies of the original files (some of these defs are not in jsfriendapi.h, for not entirely clear reasons) and then editing both original and copy to appropriately coordinate. Actually reducing dependencies must wait on additional work.

Priority: -- → P1
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/13c572d5f30a
Define |JS::shadow::String| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/769088526fa5
Define |JS::shadow::ObjectGroup| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/2fb6dbcd57b3
Define |JS::shadow::Shape| and |JS::shadow::BaseShape| in public shadow API in their own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/c3512a84d4a4
Define |JS::shadow::Object| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/a98235a07d6f
Define |JS::shadow::Function| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/f78611a8187a
Define |JS::shadow::Symbol| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/64bce271cb77
Define |JS::shadow::Zone| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/1b1827391e66
Define |JS::shadow::Realm| in public shadow API in its own minimal header.  r=jonco
You need to log in before you can comment on or make changes to this bug.