1659885 - Move shadow structure definitions to js/public/shadow

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jeff Walden [:Waldo]]

Most of these are in jsfriendapi.h right now, which means if you touch that file, you rebuild the world. On the other hand, defining them in sufficiently small separate headers should be able to reduce dependency on jsfriendapi.h. (Or it should be able to do so once the other dependencies in jsfriendapi.h on these shadow structures are moved to separate, smaller headers.)

Nothing terribly interesting here, just Mercurial copies of the original files (some of these defs are not in jsfriendapi.h, for not entirely clear reasons) and then editing both original and copy to appropriately coordinate. Actually reducing dependencies must wait on additional work.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::String| in public shadow API in its own minimal header. r=jonco!

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::ObjectGroup| in public shadow API in its own minimal header. r=jonco!

Depends on D87529

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::Shape| and |JS::shadow::BaseShape| in public shadow API in their own minimal header. r=jonco!

Depends on D87530

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::Object| in public shadow API in its own minimal header. r=jonco!

Depends on D87531

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::Function| in public shadow API in its own minimal header. r=jonco!

Depends on D87532

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::Symbol| in public shadow API in its own minimal header. r=jonco!

Depends on D87533

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::Zone| in public shadow API in its own minimal header. r=jonco!

Depends on D87534

Comment 8

[Jeff Walden [:Waldo]]

Attachment: Bug 1659885 - Define |JS::shadow::Realm| in public shadow API in its own minimal header. r=jonco!

Depends on D87535

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13c572d5f30a
Define |JS::shadow::String| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/769088526fa5
Define |JS::shadow::ObjectGroup| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/2fb6dbcd57b3
Define |JS::shadow::Shape| and |JS::shadow::BaseShape| in public shadow API in their own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/c3512a84d4a4
Define |JS::shadow::Object| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/a98235a07d6f
Define |JS::shadow::Function| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/f78611a8187a
Define |JS::shadow::Symbol| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/64bce271cb77
Define |JS::shadow::Zone| in public shadow API in its own minimal header.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/1b1827391e66
Define |JS::shadow::Realm| in public shadow API in its own minimal header.  r=jonco

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/13c572d5f30a
https://hg.mozilla.org/mozilla-central/rev/769088526fa5
https://hg.mozilla.org/mozilla-central/rev/2fb6dbcd57b3
https://hg.mozilla.org/mozilla-central/rev/c3512a84d4a4
https://hg.mozilla.org/mozilla-central/rev/a98235a07d6f
https://hg.mozilla.org/mozilla-central/rev/f78611a8187a
https://hg.mozilla.org/mozilla-central/rev/64bce271cb77
https://hg.mozilla.org/mozilla-central/rev/1b1827391e66