1659897 - Find in Page fail after Bug 1654270

Status: VERIFIED FIXED

(Core :: Find Backend, defect)

Description

[Ronald Tilby]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Login to FamilySearch.org (Accounts are free)
load this url:
https://www.familysearch.org/tree/person/sources/KWZ3-J32
press <ctrl>F to find-in-page
In the search field type: seal

Actual results:

The text in the search field turns red indicating that the search text does not occur on the page.

Expected results:

The viewport should jump to the location of the search string and color the text green.

Note that searching for: "eal" or "temple sealing" is successful.

A mozregression session showed that this problem started with the fix for bug 1654270.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Huh, interesting edge case, thanks for filing!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Reduced test-case

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1654270

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1659897 - Rewind if needed when hitting a forced break in find-in-page. r=jfkthame

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d8222cd72dc
Rewind if needed when hitting a forced break in find-in-page. r=jfkthame

Comment 7

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=O_2GknnlTgOgBMM1yk-3QQ.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C7%2Copt%2Cmochitests%2Ctest-windows7-32%2Fopt-mochitest-browser-chrome-e10s%2Cbc5&revision=0d8222cd72dccaa138dfb48f17e5e7e7f81fef2c

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313583154&repo=autoland&lineNumber=3632

Backout: https://hg.mozilla.org/integration/autoland/rev/694e4acf76559200c88b27a474f7d8782c455a04

Comment 8

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: Annoying find-in-page regression that other users have found too.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd7fb8f29da2
Rewind if needed when hitting a forced break in find-in-page. r=jfkthame

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd7fb8f29da2

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9170919 [details]
Bug 1659897 - Rewind if needed when hitting a forced break in find-in-page. r=jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: Somewhat odd find-in-page failures.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see test-case attached to the bug, also comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively small change to find-in-page code, which is well covered by tests generally.
• String changes made/needed: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9170919 [details]
Bug 1659897 - Rewind if needed when hitting a forced break in find-in-page. r=jfkthame

Approved for 81.0b5.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe5bb142d4b6

Comment 15

[Alexandra Martin]

Confirmed as verified fixed on latest Nightly 82.0a1 (20200831215215) on Windows 10 x64bit and MacOS 10.14.6.

Comment 16

[Alexandra Martin]

Also confirmed as verified fixed on latest Beta 81.0b5 (20200901203141) on Windows 10 x64bit and MacOS 10.14.6.