1659905 - CTypes variadic support is incomplete

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Mike Hommey [:glandium]]

Bug 554790 implemented variadic ctypes functions, but they're not hooked up in a way that actually works on all platforms, most notably, on Apple Silicon mac. At the very minimum, ffi_prep_cif_var should be used for these functions instead of ffi_prep_cif, but isn't.

Comment 1

[Mike Hommey [:glandium]]

Incidentally, test_jsctypes.js fails on Apple Silicon mac with: FAIL run_variadic_tests - [run_variadic_tests : 3875] -2062320572 == 6

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1659905 - Fix ctypes variadic support.

It never told libffi what the variadic arguments were.
Also fix the ctypes declaration of test_vector_add_va_cdecl in the unit test,
which is actually wrong, but the test still passed for some reason.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d5588494bec
Fix ctypes variadic support. r=jorendorff

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5d5588494bec