1659969 - Debugger is missing sources with fission enabled and remote frames

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:

• enable fission
• start firefox
• go to https://bug1659969-root.glitch.me/
• open Debugger

ER:
Debugger should show sources from the parent page and from the remote frames

AR:
Debugger only shows sources for the remote frame

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1659969 - [devtools] Add Debugger test for sources from remote frames

Comment 2

[Julian Descottes [:jdescottes]]

Added a mochitest that currently fails with fission because it shows one interesting thing: all sources are correctly in the state, but the source tree only shows the remote one.

Comment 3

[Julian Descottes [:jdescottes]]

I tried to bisect a bit, but I am not sure we ever supported fission frames for the debugger in the content toolbox.
In older revisions, instead of seeing only the frame sources, we see the root sources. I am not sure when this changed to show only frame sources, but it never worked perfectly it seems.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can simply reproduce the issue on my machine. Thanks Julian for the test case.
I see both sources when Fission is disabled.

Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

We should retest as soon as bug 1620280 lands. There is a chance this could be fixed.

Comment 6

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #5)

We should retest as soon as bug 1620280 lands. There is a chance this could be fixed.

I can still reproduce the reported issue.

Comment 8

[Alexandre Poirot [:ochameau]]

(In reply to Julian Descottes [:jdescottes] from comment #3)

I tried to bisect a bit, but I am not sure we ever supported fission frames for the debugger in the content toolbox.
In older revisions, instead of seeing only the frame sources, we see the root sources. I am not sure when this changed to show only frame sources, but it never worked perfectly it seems.

+1, additional frame targets were all considered "main thread type":
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/client/firefox/create.js#101-111
and so later on in the reducer:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers/threads.js#95
returned an empty list of additional targets.

It is probably time for the debugger to use regular target object instead of wrapping it to yet another different type of objects with different attributes.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1659969 - [devtools] Use isTopLevel attribute to know if a given target is the "main one".

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1659969 - [devtools] Pass TargetMixin.targetType to debugger codebase in order to distinguish the targets.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d30d1bcf966c
[devtools] Use isTopLevel attribute to know if a given target is the "main one". r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/ae2c48cf3d57
[devtools] Pass TargetMixin.targetType to debugger codebase in order to distinguish the targets. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/f685f13226cd
[devtools] Add Debugger test for sources from remote frames r=ochameau

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d30d1bcf966c
https://hg.mozilla.org/mozilla-central/rev/ae2c48cf3d57
https://hg.mozilla.org/mozilla-central/rev/f685f13226cd