1660064 - When printing a subdocument and using 'Save to PDF', the generated filename is wrong

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Jonathan Watt [:jwatt]]

When opening the context menu over a subdocument and selecting This Frame -> Print frame..., and then in the print preview choosing 'Save as PDF', the prepopulated filename is supposed to come from the title of the document being printed. Currently, it is incorrectly being generated from the title of the top-level document.

This is happening because pickFileName uses sourceBrowser.currentURI.spec. Instead of getting the title from the XUL browser for the tab, the title should come from the source BrowsingContext.

Comment 1

[Jonathan Watt [:jwatt]]

Although I guess it's a bit hard to repro this until bug 1659859 is fixed, or until bug 1602410 makes it to m-c. (Although for the latter you need to mess with the devtools console, which isn't quite as simple.)

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1660064 - Use subdocument info when saving a subdocument to PDF r?jwatt,sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32a10a7c83ae
Use subdocument info when saving a subdocument to PDF r=jwatt

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/32a10a7c83ae