Closed Bug 1660095 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 25119 - [LayoutNG] Correct border painting for block fragmentation.

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25119 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25119
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Correct border painting for block fragmentation.

Add a few new tests, as coverage seemed low.

Fix PhysicalBoxSides writing-mode converter to handle vertical-lr, and
skip sideways-lr and sideways-rl, since those aren't even supported by
the CSS parser.

Update BackgroundRoundedRectAdjustedForBleedAvoidance() to skip the
borders that aren't part of the fragment. I suppose inline fragmentation
wasn't using this code path, but block fragmentation uses it.

Bug: 829028
Change-Id: I7e3f78a4fde54c7da1442efdabe609651cd27d10
Reviewed-on: https://chromium-review.googlesource.com/2362902
WPT-Export-Revision: 7c0b8dd8fb1869e5b4a7d645a2a033c6e8b394e8

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

PASS: 4
FAIL: 4

Chrome

PASS: 2
FAIL: 6

Safari

PASS: 2
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/borders-007.html: FAIL

New Tests That Don't Pass

/css/css-break/borders-003.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/borders-007.html: FAIL (Chrome: PASS, Safari: PASS)
/css/css-break/borders-005.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-break/borders-004.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87ee5d4898ac
[wpt PR 25119] - [LayoutNG] Correct border painting for block fragmentation., a=testonly
https://hg.mozilla.org/integration/autoland/rev/789c0009ccab
[wpt PR 25119] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.