1660107 - Assertion failure: mStreamType != StreamType::Unknown, at /Users/haftandilian/r/mc/dom/media/platforms/apple/AppleVTDecoder.cpp:78

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Haik Aftandilian [:haik]]

On a debug macOS Nightly build, running on macOS 11 Beta 4 (20A5343i), attempting to visit youtube.com results in the following ASSERT crash:

Assertion failure: mStreamType != StreamType::Unknown, at dom/media/platforms/apple/AppleVTDecoder.cpp:78

which was added for bug 1657521. Abbreviated stack:

Assertion failure: mStreamType != StreamType::Unknown, at /Users/haftandilian/r/mc/dom/media/platforms/apple/AppleVTDecoder.cpp:78
#01: mozilla::AppleVTDecoder::AppleVTDecoder(mozilla::VideoInfo const&, mozilla::layers::ImageContainer*, mozilla::EnumSet<mozilla::CreateDecoderParams::Option, unsigned int>, mozilla::layers::KnowsCompositor*)[/Users/haftandilian/r/mc/obj-dbg.noindex/toolkit/library/build/XUL +0x60c1898]
#02: mozilla::AppleVTDecoder::AppleVTDecoder(mozilla::VideoInfo const&, mozilla::layers::ImageContainer*, mozilla::EnumSet<mozilla::CreateDecoderParams::Option, unsigned int>, mozilla::layers::KnowsCompositor*)[/Users/haftandilian/r/mc/obj-dbg.noindex/toolkit/library/build/XUL +0x60c1b7d]
#03: mozilla::AppleDecoderModule::CanCreateVP9Decoder()[/Users/haftandilian/r/mc/obj-dbg.noindex/toolkit/library/build/XUL +0x608dba2]
#04: mozilla::AppleDecoderModule::Init()[/Users/haftandilian/r/mc/obj-dbg.noindex/toolkit/library/build/XUL +0x608d9a4]
#05: mozilla::PDMFactoryImpl::PDMFactoryImpl()[/Users/haftandilian/r/mc/obj-dbg.noindex/toolkit/library/build/XUL +0x6091301]
#06: mozilla::PDMFactoryImpl::PDMFactoryImpl()[/Users/haftandilian/r/mc/obj-dbg.noindex/toolkit/library/build/XUL +0x60911b5]
#07: mozilla::PDMFactory::EnsureInit()::$_7::operator()() const[/Users/haftandilian/r/mc/obj-dbg.noindex/toolkit/library/build/XUL +0x6073432]

$ hg parent
changeset: 545065:aa98a6ece5fb
user: Jean-Yves Avenard <[e-mail]>
date: Mon Aug 17 22:40:47 2020 +0000
summary: Bug 1659015 - P4. Backport AVIF dav1d colorspace changes to DAV1DDecoder. r=jbauman

Comment 1

[Jean-Yves Avenard [:jya]]

What mStreamType value would that be?

Do you have a link to the actual video?

The AppleVTDecoder should only ever be called for VP9 (if hardware decoding is supported) or H264 , it can't handle anything else.

Comment 2

[Jean-Yves Avenard [:jya]]

oops, never mind.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1660107 - Set proper mimetype. r?jolin

Comment 4

[Haik Aftandilian [:haik]]

@jya, thanks for the quick fix. Are we missing a test case for this or is it just that this feature requires 10.15 and that is not available on automation? I expect we will have 10.15 soon to support testing on ARM-based Macs. -- (Edit: I meant 11.0 here, not 10.15.)

Comment 5

[Jean-Yves Avenard [:jya]]

(In reply to Haik Aftandilian [:haik] from comment #4)

@jya, thanks for the quick fix. Are we missing a test case for this or is it just that this feature requires 10.15 and that is not available on automation? I expect we will have 10.15 soon to support testing on ARM-based Macs.

this will indeed require macOS 11 beta 4 (not available in earlier beta). The symbol VTRegisterSupplementalVideoDecoderIfAvailable can only be resolved there.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee727292d69c
Set proper mimetype. r=jolin

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ee727292d69c