1660187 - Assertion on zero-length GL version string

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Henri Sivonen (:hsivonen)]

This Pernosco session shows a failure to parse a GL version out of a zero-length version string:
https://pernos.co/debug/T2SnBKzMNDY3U8jJWDR_Xg/index.html

Assertion failure: false (Failed to parse GL_VERSION), at /builds/worker/checkouts/gecko/gfx/gl/GLContext.cpp:544

It's unclear to me if this is a user-relevant problem or an artifact of what Pernosco/rr does to avoid having to record the real GPU.

Anyway, this interferes with getting Pernosco to repro problems elsewhere in the code base.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1660187 - Don't assert if the GL version string is empty. r=jgilbert

It can happen with Pernosco, getting in the way of reproducing problems elsewhere in the code base.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9383e6be8da0
Don't assert if the GL version string is empty. r=jgilbert

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9383e6be8da0