1660231 - Enable MASTER_PASSWORD_ENABLED probe on release

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P2)

Description

[Romain Testard [:RT]]

This probe is on pre-release only. Assessing share of DAU/MAUusing the feature will help understand:

• Criticality of bringing improvements to the feature
• Criticality of addressing scenarios where users share their desktop with other iusers (i.e improve profile management to make it user friendly)

Comment 1

[Romain Testard [:RT]]

Attachment: data review form

Hi Chris, can you please help with a data review?

Comment 2

[Chris H-C :chutten]

Comment on attachment 9171193 [details]
data review form

The request says "monitor this data for 6 months" but the stated probe does not expire. Please identify a person responsible for monitoring this permanent data collection.

Comment 3

[Romain Testard [:RT]]

Attachment: datareviewform

New data review form requesting the probe to not expire and setting myself as responsible for monitoring the probe permanent collection

Comment 4

[Romain Testard [:RT]]

Comment on attachment 9173552 [details]
datareviewform

Re requesting review now that I addressed the comments

Comment 5

[Chris H-C :chutten]

Comment on attachment 9173552 [details]
datareviewform

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Romain Testard is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 6

[Sam Foster [:sfoster] (he/him)]

Looks like this is ready to go, and just needs a patch.
My suspicion is there is a large overlap between people that enable primary password and people that disable telemetry, for what that is worth. But I see no reason not to turn this on on release and at least find out more.

Comment 7

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1660231 - Convert MASTER_PASSWORD_ENABLED (Primary Password enabled) histogram to opt-out for the release channel. r?jaws

Comment 8

[Sam Foster [:sfoster] (he/him)]

Patch attached. I didn't update the description to use "primary password" but maybe that is a change that can be done at the same time.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0afb41084c0
Convert MASTER_PASSWORD_ENABLED (Primary Password enabled) histogram to opt-out for the release channel. r=jaws

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e0afb41084c0