Improve Assertions When Testing Printer Paper Sizes
Categories
(Core :: Printing: Setup, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox81 | --- | fixed |
People
(Reporter: nordzilla, Assigned: nordzilla)
Details
Attachments
(1 file, 1 obsolete file)
Some of the assertions for testing printer paper sizes check that certain attributes are not equal to null.
This is not a good way of asserting things, because undefined is also not equal to null. Something as simple as having a typo in the name of the attribute would pass that assertion because it is undefined.
A better assertion would be to assert that the type of the attribute matches the expected type.
Assignee | ||
Comment 1•4 years ago
|
||
This improves the paper assertions to check for attribute type, rather
than checking if the attribute is null, since undefined is not null and
can cause false positives.
Also updates the formatting to be congruent with other related tests.
Pushed by rmaries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5944dfb5b951 Improve Print Paper Size Test Assertions r=dholbert
Assignee | ||
Comment 3•4 years ago
|
||
This patch adds a boolean to nsIPaper for whether duplex printing is
supported for that paper size on a given printer. To start simply, each
paper will reflect the printer's duplex support as a whole. This is no
different from the current setup which, has supportsDuplex as an
attribute of the printer itself. Part 2 will add more grandular info.
Updated•4 years ago
|
Comment 4•4 years ago
|
||
bugherder |
Description
•