1660288 - Lint hook broken after python updates

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P2)

Description

[:Gijs (he/him)]

Commit produces:

  File "path/to/tools/lint/hooks.py", line 50, in hg
    return run_mozlint(hooktype, kwargs.get("pats", []))
  File "path/to/tools/lint/hooks.py", line 37, in run_mozlint
    if "commit" in hooktype:
TypeError: a bytes-like object is required, not 'str'

Mark or :ahal, do you know what this is about? I've had to disable the lint hook so I can commit...

Comment 1

[Andrew Halberstadt [:ahal]]

Ah, likely you upgraded Mercurial to a version that uses Python 3 by default.

For context, Mercurial uses byte strings internally, which is the default string type with Python 2, but is incompatible with the default type in Python 3. I'm surprised it took this long for a bug be filed..

I'll add this to my queue (though I'm a bit swamped with the layoffs atm).

Comment 2

[:Gijs (he/him)]

comment #1 is enough context that I think I can just fix this - thanks! I'll steal this and you can steal it back if my patch is rubbish. :-)

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1660288 - fix python3 errors in the linter's hooks.py tripped when using python3-based mercurial, r?ahal

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f006849e5c5
fix python3 errors in the linter's hooks.py tripped when using python3-based mercurial, r=ahal

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/662ab7cde7da
Fixing the lint failure. CLOSED TREE

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5f006849e5c5
https://hg.mozilla.org/mozilla-central/rev/662ab7cde7da