1660323 - Perma tier 2 TEST-UNEXPECTED-FAIL | firefox/browser/modules/themes/alpenglow differs. See the diff.html or diff.txt artifact

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=313581304&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AjyhFuGURQ6bDtYYMohpyg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-08-20T18:59:49.593Z] + report_error diff
[task 2020-08-20T18:59:49.593Z] + python3
[task 2020-08-20T18:59:49.602Z] TEST-UNEXPECTED-FAIL | firefox/browser/modules/themes/alpenglow differs. See the diff.html or diff.txt artifact
[task 2020-08-20T18:59:49.602Z] TEST-UNEXPECTED-FAIL | firefox/modules/themes differs. See the diff.html or diff.txt artifact
[task 2020-08-20T18:59:49.604Z] + fail
[task 2020-08-20T18:59:49.604Z] + exit 1
[taskcluster 2020-08-20 18:59:49.927Z] === Task Finished ===
[taskcluster 2020-08-20 18:59:50.207Z] Unsuccessful task run with exit code: 1 completed in 37.587 seconds

Comment 1

[Razvan Maries]

Mike, could you take a look?

Comment 2

[Razvan Maries]

Fixed by: https://hg.mozilla.org/integration/autoland/rev/564a3a6c2eb1aa1bf6c1bfb71a15ce382e6b8141

Comment 3

[Intermittent Failures Robot]

2 failures in 4100 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• diff: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1660323&startday=2020-08-17&endday=2020-08-23&tree=all

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1643776

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

:glandium, do you have any idea how it is that the SVGs could occasionally end up in wrong place? Perhaps this is related to what you wrote in bug 1660557?

In any case, installing the theme files via EXTRA_JS_MODULES is a misuse of the variable.

All the themes in browser/themes/addons do this.

I'm guessing that the right way to install them would be using a jar.mn?

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Moving this to P1, since I suspect that if we shipped a package based on this, the theme wouldn't work in that package...

:ryanvm, I'm confused why would this be fixed in Firefox 81?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Because bug 1643776 landed during the 81 cycle. I'm confused why we're doing something in this bug now when AFAICT the original problem was corrected when bug 1643776 relanded?

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

My assumption was that you assigning to me meant that there was still a problem, and that you had just forgotten to reopen it. Ok, so never mind then!