1660328 - Implement directory iterator for IOUtils

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, enhancement)

Description

[Keefer Rourke]

IOUtils does not currently implement a directory iterator. It would be great to support asynchronous iteration over directory entries.

Comment 1

[Keefer Rourke]

For idiomatic directory iteration, this might require support for web IDL's async iterables.

Comment 2

[Keefer Rourke]

@barret points out that rather than making a new instantiable async directory iteratory, we can probably just add a method like the following to IOUtils:

namespace IOUtils {
  Promise<Sequence<DOMString>> getChildren(DOMString path);
}

which would be used as for (const dirEntry of await IOUtils.getChildren(DOMString path)), removing the need for async iterable support for this feature.

Comment 3

[Keefer Rourke]

Attachment: Bug 1660328: Implement IOUtils::getChildren method r?barret!,Gijs!

This change introduces a getChildren method to the IOUtils interface, which
returns an array of absolute paths pointing to the immediate children of a
directory.

This method should provide equivalent functionality to creating a new
OS.File.DirectoryIterator.

Depends on D87873

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff95badf90e3
Implement IOUtils::getChildren method r=barret,Gijs

Comment 5

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=CiWHaxoMQOekzAfASubjrg.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=ff95badf90e3d7cbc6490b1fb96317de1aab0d7d&failure_classification_id=2&searchStr=xpcshell

Logs:
XPCSHELL:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314044781&repo=autoland&lineNumber=2795
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314044782&repo=autoland&lineNumber=4593
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314045620&repo=autoland&lineNumber=5959
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314045636&repo=autoland&lineNumber=6463

Marionette:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314046376&repo=autoland&lineNumber=58417

TV: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314045025&repo=autoland&lineNumber=5781

Backout: https://hg.mozilla.org/integration/autoland/rev/db87b470f1d494518772248e0c34ec49dbded629

Comment 6

[Keefer Rourke]

Hm, I've reordered the commits in the patchset that @barret tried to land yesterday. These failures aren't related to this bug, but rather to changes I made to address bug 1649595.

We can try to reland this change today, while I investigate the CrashMonitor unit test failures.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f154c83412cf
Implement IOUtils::getChildren method r=barret,Gijs

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on IOUtils.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/827f8ba12fdbabb7b19b36368a33dd27cd4954af
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314117709&repo=autoland&lineNumber=13875

Comment 9

[Keefer Rourke]

This was a result of an error with rebasing some of my patches, sorry! Fixed in patch D87875 :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a9bdc86cff7
Implement IOUtils::getChildren method r=barret,Gijs

Comment 11

[Razvan Maries]

Backed out for build bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=e2nevQdzREyBAUnFdBUrSQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=7d76fc9a1d417461b82289a2f277c65628417ac6&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains-clang%2Fdebug%2Cbbc

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314255099&repo=autoland&lineNumber=11346

Backout: https://hg.mozilla.org/integration/autoland/rev/69c9cafe09e9d53c93845ac5232171bbc7f8ebca

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5943b631af6e
Implement IOUtils::getChildren method r=barret,Gijs

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5943b631af6e