1660346 - Intermittent js/src/jit-test/tests/gc/helper-thread-params.js | Timeout (code -6, args "") [150.0 s]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=313584196&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/XA3FeIr0QXWLTUzgznNp7g/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-08-20T21:01:25.921Z] TEST-PASS | js/src/jit-test/tests/ion/super-getelem-profiling.js | Success (code 0, args "--baseline-eager") [0.6 s]
[task 2020-08-20T21:01:26.026Z] Exit code: -6
[task 2020-08-20T21:01:26.026Z] TIMEOUT - gc/helper-thread-params.js
[task 2020-08-20T21:01:26.026Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/gc/helper-thread-params.js | Timeout (code -6, args "") [150.0 s]
[task 2020-08-20T21:01:26.026Z] INFO exit-status : -6
[task 2020-08-20T21:01:26.026Z] INFO timed-out : 0:00:00.028384

Comment 1

[Intermittent Failures Robot]

2 failures in 4100 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• mozilla-central: 1

Platform breakdown:

• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1660346&startday=2020-08-17&endday=2020-08-23&tree=all

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1660346 - Rework helper thread creation to allow more threads to be added r?sfink

Previously HelperThread instances lived in the GlobalHelperThreadState vector.
This meant that resizing the vector could move the objects in memory which was
not safe. Also HelperThread members were not always initialized. I'm not sure
how this managed to work.

This changes the vector to contain pointers to HelperThreads which now won't
get moved. Also, for some reason the vector itself was a separate allocation
which was unnecessary. The patch makes this part of the main object.

I added a threads() method taking a lock reference since the thread list can
now change after initialization. Finally I simplified the thread creation
loop.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13f1813b7ce8
Rework helper thread creation to allow more threads to be added r=sfink

Comment 4

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Cwithout%2Ce10s%2Ctest-linux1804-64-asan%2Fopt-mochitest-chrome-1proc%2Cc3&revision=13f1813b7ce8f44af16e5708f3249ec1625236e8&selectedTaskRun=cR0_C_xXRI-uUtmhZVnnIQ.0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313983683&repo=autoland&lineNumber=113974

Backout: https://hg.mozilla.org/integration/autoland/rev/766f836f9a980b81d4e3f1473888d39e742364a1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1aebd8ee631
Rework helper thread creation to allow more threads to be added r=sfink

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1657850

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a1aebd8ee631

Comment 8

[Intermittent Failures Robot]

3 failures in 4046 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform breakdown:

• linux64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1660346&startday=2020-08-24&endday=2020-08-30&tree=all