1660378 - Fix debug warning spam of style editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The spam makes me harder to investigate test failures of my patches. And as I investigated, the QI timing is too late. They are performed in for loop for same instance so that fixing this must improve the response for changing style with editor API.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

There are 2 different warnings which are logged too many.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay, coming patch gets rid of 4000+ warnings when I run all tests under editing of WPT.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 1: Get rid of `CSSEditUtils::GetInlineStyles()` r=m_kato!

It should take nsStyledElement& instead of const Element&. Then, it
always returns NS_OK so that it can just return
already_AddRefed<nsICSSDeclaration> instead.

Depends on D87439

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 2: Make `CSSEditUtils::RemoveCSSPoperty()` take `nsStyledElement&` instead of `Element&` r=m_kato!

Depends on D87982

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 3: Make `CSSEditUtils::RemoveCSSEquivalentToHTMLStyle()` take `nsStyledElement&` instead of `Element*` r=m_kato!

Depends on D87983

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 4: Make `CSSEditUtils::DoElementsHaveSameStyle()` take `nsStyledElement&` instead of `Element&` r=m_kato!

Depends on D87984

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 5: Make `CSSEditUtils::RemoveCSSInlineStyle()` take `nsStyledElement&` instead of `nsINode&` r=m_kato!

Depends on D87985

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 6: Make `CSSEditUtils::SetCSSProperty()` and its callers take `nsStyledElement&` instead of `Element&` r=m_kato!

Depends on D87986

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 7: Make `CSSEditUtils::SetCSSEquivalentToHTMLStyle()` take `nsStyledElement&` instead of `Element*` r=m_kato!

Depends on D87987

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 8: Make `HTMLEditor::IsSimpleModifiableNode()` take `Element&` instead of `nsIContent*` r=m_kato!

Although it starts to return error if it causes destroying the editor, but
it should not occur because it modifies new and orphan node and it shouldn't
kick any mutation event listeners. Therefore, this patch makes the callers
handle error as-is rather than ignoring errors except
NS_ERROR_EDITOR_DESTROYED.

Depends on D87988

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1660378 - part 9: Avoid QI for getting `nsStyledElement` pointer r=smaug!

The editor modules does QI too many times when it sets or removes some style
with execCommand or XPCOM API. Therefore, there should be an API to
retrieve nsStyledElement pointer from nsINode*.

Depends on D87989

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ee8df5f9eb9
part 1: Get rid of `CSSEditUtils::GetInlineStyles()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ee82ab27ad02
part 2: Make `CSSEditUtils::RemoveCSSPoperty()` take `nsStyledElement&` instead of `Element&` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ac6b4ebdf316
part 3: Make `CSSEditUtils::RemoveCSSEquivalentToHTMLStyle()` take `nsStyledElement&` instead of `Element*` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c4e47e9e0e38
part 4: Make `CSSEditUtils::DoElementsHaveSameStyle()` take `nsStyledElement&` instead of `Element&` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/13c9b2ffe14c
part 5: Make `CSSEditUtils::RemoveCSSInlineStyle()` take `nsStyledElement&` instead of `nsINode&` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5e5fa801260f
part 6: Make `CSSEditUtils::SetCSSProperty()` and its callers take `nsStyledElement&` instead of `Element&` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/06759e45f873
part 7: Make `CSSEditUtils::SetCSSEquivalentToHTMLStyle()` take `nsStyledElement&` instead of `Element*` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ee4715363f70
part 8: Make `HTMLEditor::IsSimpleModifiableNode()` take `Element&` instead of `nsIContent*` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d1a42f86dd61
part 9: Avoid QI for getting `nsStyledElement` pointer r=smaug

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7ee8df5f9eb9
https://hg.mozilla.org/mozilla-central/rev/ee82ab27ad02
https://hg.mozilla.org/mozilla-central/rev/ac6b4ebdf316
https://hg.mozilla.org/mozilla-central/rev/c4e47e9e0e38
https://hg.mozilla.org/mozilla-central/rev/13c9b2ffe14c
https://hg.mozilla.org/mozilla-central/rev/5e5fa801260f
https://hg.mozilla.org/mozilla-central/rev/06759e45f873
https://hg.mozilla.org/mozilla-central/rev/ee4715363f70
https://hg.mozilla.org/mozilla-central/rev/d1a42f86dd61