Closed Bug 1660400 Opened 4 years ago Closed 4 years ago

Sheet count should be included in modal a11y description

Categories

(Toolkit :: Printing, enhancement, P2)

Product:
Toolkit
Component:
Printing
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Project Flags:
Accessibility Severity s4
Tracking Flags:
Tracking Status
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: Jamie, Assigned: Jamie)

References

Details

(Keywords: access, Whiteboard: [print2020_v81])

Attachments

(1 file)

Bug 1660400: Include sheet count in Print modal a11y description and make it a live region.
47 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

STR (with the NVDA screen reader):

  1. Open this URL:
    data:text/html,test
  2. Press control+p to open the Print modal.
    • Expected: Before speaking the destination, NVDA should speak the sheet count.
    • Actual: The sheet count isn't reported.

This can be fixed by adding aria-describedby="sheet-count" to the body element for the print page.

Severity: -- → S4
Priority: -- → P2
Whiteboard: [access-s4] → [access-s4][print2020_v81]
Assignee: nobody → jteh
Status: NEW → ASSIGNED
Attachment #9171600 - Attachment description: Bug 1660400: Include sheet count in Print modal a11y description. → Bug 1660400: Include sheet count in Print modal a11y description and make it a live region.
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebfa542ac69a
Include sheet count in Print modal a11y description and make it a live region. r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/ebfa542ac69a

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Do you want to request Beta uplift for this?

Flags: needinfo?(jteh)

Comment on attachment 9171600 [details]
Bug 1660400: Include sheet count in Print modal a11y description and make it a live region.

Beta/Release Uplift Approval Request

  • User impact if declined: Screen readers will find it difficult or impossible to access the sheet count in the new print modal.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simply adds (well understood) attributes that are picked up by the accessibility engine.
  • String changes made/needed: None.
Flags: needinfo?(jteh)
Attachment #9171600 - Flags: approval-mozilla-beta?

Comment on attachment 9171600 [details]
Bug 1660400: Include sheet count in Print modal a11y description and make it a live region.

Approved for 81.0b5.

Attachment #9171600 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Accessibility Severity: --- → s4
Whiteboard: [access-s4][print2020_v81] → [print2020_v81]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: