1660452 - NullPrincipals need to know whether they were spun off of a Secure Context

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Description

[Frederik Braun [:freddy]]

Currently, the mixed content blocker is looking at NullPrincipals on their own, to decide whether blocking makes sense. NullPrincipals do not use an HTTPS URL-scheme and are therefore excluded from MCB checks.

We should to avoid finding a handle to the owning document of the NullPrincipal because that may pass process boundaries (and violate Site Isolation / Project Fission).

Instead, I am proposing to add that flag as a boolean flag to the NullPrincipal and change the Secure Context flag for the NullPrincipal (which currently is hardcoded false).

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Yeah, I would like to get that fixed rather sooner than later actually - also because it would allow us to run more wpt tests in the tree.

Comment 2

[Frederik Braun [:freddy]]

Fixing this involves:

• adding a boolean member to the NullPrincipal class to say whether we are in a secure context.
• adjust GetIsOriginPotentiallyTrustworthy to use that flag

Setting that flag is a bit tricky:
NullPrincipals are created using one of many NullPrincipal::Create... functions, which are then routed through the main Create() function, which all call the object constructor eventually.
We already lose most context inside of the various Create.. functions, so we need to modify all of them to take a value for the flag based on the current document that creates the NullPrincipal.

I'm merely hoping that we can get the info for that boolean flag in all callsites though.

Comment 3

[Frederik Braun [:freddy]]

Attachment: Bug 1660452 - make NullPrincipal aware of its creator's SecureContext bits r=ckerschb

Comment 4

[Niklas]

Attachment: Bug 1660452: Use precusor URIs to determine if a NullPrincipal was spun off of a Secure Context. r=ckerschb

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06b855d93dad
Use precusor URIs to determine if a NullPrincipal was spun off of a Secure Context. r=ckerschb

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_bug1660452_https.html

• backout: https://hg.mozilla.org/integration/autoland/rev/03d2c45cdd6bc00e26bc726b74d90237a629a5f4

• push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=06b855d93dad8babd10c8ce37ed642974d383914&group_state=expanded&selectedTaskRun=LJ6EQ_NkS8auT3_9pr55hw.0

• failure log: https://treeherder.mozilla.org/logviewer?job_id=346041612&repo=autoland&lineNumber=5349

[task 2021-07-22T16:08:22.385Z] 16:08:22     INFO - TEST-PASS | dom/security/test/general/test_bug1660452_https.html | data uri window should be a secure context 
[task 2021-07-22T16:08:22.385Z] 16:08:22     INFO - Buffered messages finished
[task 2021-07-22T16:08:22.385Z] 16:08:22     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/test_bug1660452_https.html | Test timed out. - 
[task 2021-07-22T16:08:23.265Z] 16:08:23     INFO - GECKO(4680) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2021-07-22T16:08:23.268Z] 16:08:23     INFO - GECKO(4680) | MEMORY STAT | vsize 2524MB | residentFast 127MB | heapAllocated 5MB
[task 2021-07-22T16:08:23.275Z] 16:08:23     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-07-22T16:08:23.276Z] 16:08:23     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/test_bug1660452_https.html | data uri frames should be a secure context 
[task 2021-07-22T16:08:23.277Z] 16:08:23     INFO - SimpleTest.ok@https://example.org/tests/SimpleTest/SimpleTest.js:417:16
[task 2021-07-22T16:08:23.278Z] 16:08:23     INFO - @https://example.org/tests/dom/security/test/general/test_bug1660452_https.html?currentTestURL=dom%2Fsecurity%2Ftest%2Fgeneral%2Ftest_bug1660452_https.html&closeWhenDone=1&showTestReport=true&expected=pass:21:7
[task 2021-07-22T16:08:23.324Z] 16:08:23     INFO - TEST-OK | dom/security/test/general/test_bug1660452_https.html | took 301088ms

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5feb9c65eca
Use precusor URIs to determine if a NullPrincipal was spun off of a Secure Context. r=ckerschb

Comment 8

[Cristian Tuns]

Backed out for causing web-tests failures on basic-popup-and-iframe-tests.https.html

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6438f7af974a
Use precusor URIs to determine if a NullPrincipal was spun off of a Secure Context. r=ckerschb

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6438f7af974a