Closed
Bug 1660699
Opened 4 years ago
Closed 4 years ago
Store JSAtom in CompilationInfo instead of ParserAtom
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
82 Branch
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
ParserAtom is part of stencil and it shouldn't contain GC pointer
we should move it into CompilationInfo (eventually CompilationGCOutput in bug 1649968) and store index into it in ParserAtom
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
ParserAtom now holds either AtomIndex that is an index into
CompilationInfo.atoms, or WellKnownAtomKind that maps to cx->names() fields.
ParserAtoms in WellKnownParserAtoms holds WellKnownAtomKind,
and ParserAtoms in CompilationInfo.parserAtoms holds AtomIndex.
GetWellKnownAtom relies on the struct layout of JSAtomState, to
quickly map WellKnownParserAtoms to its field.
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/4b43e587a0bc Store JSAtom in CompilationInfo. r=tcampbell
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•