Open Bug 1660716 Opened 4 years ago Updated 4 years ago

[wpt-sync] Sync PR 25203 - [Web Payment] Secure payment confirmation SQLite tables.

Categories

(Core :: DOM: Web Payments, task, P4)

task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25203 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25203
Details from upstream follow.

Rouslan Solomakhin <rouslan@chromium.org> wrote:

[Web Payment] Secure payment confirmation SQLite tables.

Before this patch, there wasn't any place in Chrome for WebAuthn to
store the payment-specific information of PaymentCredential that could
also be accessed by Web Payments for secure payment confirmation method.

This patch adds SQLite tables for storing secure payment confirmation
instrument information: relying party, identifier, label, icon, and a
list of WebAuthn credential identifiers. The secure payment confirmation
app factory reads the tables for creating an app. To avoid instrument
identifier collision among different relying parties, PaymentRequest
constructor now requires a relying party identifier as well.

After this patch, WebAuthn has a place to store the payment-specific
information of PaymentCredential in Chrome and Web Payment has access to
it as well.

Design: https://bit.ly/secure-payment-confirmation
Explainer: https://github.com/rsolomakhin/secure-payment-confirmation

Bug: 1110320
Change-Id: Ic1e9d5dca20a38bebbd35cbd9bd0aabd9a237da1
Reviewed-on: https://chromium-review.googlesource.com/2368463
WPT-Export-Revision: ec9861e2119a2bea416b886740081fe70647e050

PR 25203 applied with additional changes from upstream: 2df9cdd7a2dcba842ff653c1015ed6a971eb2317, 71d8953f0c3fbddbd22e669625efc19d209790cf, b5bae34e89a1b10f4ea8221394a3050f30861f8e, 51c3b507c3732ffd4b6e2bd37c938b76c623eec0, 3fce2a54ca50a69e52ebc71070d89197e5b42e75, 2f79fdd170945fb988568274655c348551e5723f
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 17 subtests

Status Summary

Firefox

OK : 1
FAIL: 17

Chrome

OK : 1
PASS: 12
FAIL: 5

Safari

OK : 1
PASS: 3
FAIL: 14

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/payment-request/secure-payment-confirmation.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
The networkData field is required.: FAIL (Chrome: PASS, Safari: FAIL)
Empty credentialIds field throws exception.: FAIL (Chrome: FAIL, Safari: FAIL)
Cannot request payer phone.: FAIL (Chrome: PASS, Safari: FAIL)
Cannot request shipping information.: FAIL (Chrome: PASS, Safari: FAIL)
The fallbackUrl field is required.: FAIL (Chrome: PASS, Safari: FAIL)
Cannot request payer name.: FAIL (Chrome: PASS, Safari: FAIL)
Valid payment method data does not throw exceptions.: FAIL (Chrome: FAIL, Safari: PASS)
The timeout field is optional.: FAIL (Chrome: FAIL, Safari: PASS)
Extra payment method not allowed beforehand.: FAIL (Chrome: PASS, Safari: FAIL)
Extra payment method not allowed afterward.: FAIL (Chrome: PASS, Safari: FAIL)
Empty networkData field throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
The action field is optional.: FAIL (Chrome: FAIL, Safari: PASS)
The credentialIds field is required.: FAIL (Chrome: PASS, Safari: FAIL)
Cannot request payer email.: FAIL (Chrome: PASS, Safari: FAIL)
Null networkData field throws exception.: FAIL (Chrome: PASS, Safari: FAIL)
Timeout longer than 1 hour throws exception.: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid action parameter throws an exception.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/payment-request/secure-payment-confirmation.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

You need to log in before you can comment on or make changes to this bug.