Closed Bug 1660750 Opened 4 years ago Closed 4 years ago

Fix AndroidHardwareBufferManager::WaitForBufferOwnership()

Categories

(Core :: Graphics, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Implementation of WaitForBufferOwnership() is naive. When mMonitor.NotifyAll() is not called in NotifyNotUsed(), mMonitor.Wait() could wait forever. And 10 seconds timeout seems too long.

comment from :jnicol

If that is the case, is 10 seconds too long? That might cause poor performance, and also we won't get the benefit of gfxCriticalNote showing up in crash reports for shorter waits.

Assignee: nobody → sotaro.ikeda.g
Blocks: 1562818
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13ffdb654409
Fix timeout handling of AndroidHardwareBufferManager::WaitForBufferOwnership() r=jnicol
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: