1660751 - QM: Log failures in the browser console

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

Now when we have mostly complete replacement for NS_ENSURE_SUCCESS/NS_WARN_IF, we can start adding more features. Logging to the browser console is one of them.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1660751 - QM: Log failures in the browser console; r=#dom-workers-and-storage-reviewers

Depends on D87834

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1660751 - Make HandleError function MOZ_NEVER_INLINE. r=#dom-workers-and-storage,janv

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1660751 - Use bare const char* in HandleError signature to reduce size of calling code. r=#dom-workers-and-storage

Not that this is deliberately de-optimizing performance: Now, the HandleError
functions need to use the nsDependentCString constructor to determine the
length of the literals at run-time, since that's lost. While passing that
in addition would reduce the binary size wins again, and is not necessary,
since this code is only called in error situations, which are not
performance-critical.

Depends on D89147

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d36aba44469
QM: Log failures in the browser console; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/bb95b821eee6
Make HandleError function MOZ_NEVER_INLINE. r=janv,dom-workers-and-storage-reviewers
https://hg.mozilla.org/integration/autoland/rev/446aa773c333
Use bare const char* in HandleError signature to reduce size of calling code. r=dom-workers-and-storage-reviewers,janv

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1d36aba44469
https://hg.mozilla.org/mozilla-central/rev/bb95b821eee6
https://hg.mozilla.org/mozilla-central/rev/446aa773c333