1660816 - Make PBackgroundIDBCursor protocol refcounted

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=#dom-workers-and-storage

Comment 2

[Tom Ritter [:tjr] (OOTO until 9/2)]

Required for blocker uplift which I think we should do...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b9687fb7d41
Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth

Comment 4

[Razvan Maries]

Backed out as requested on Riot: https://hg.mozilla.org/integration/autoland/rev/451620a788ec7c0dbd59210c5889188520b32874

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f16b2746e674
Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth

Comment 6

[Ryan VanderMeulen [:RyanVM]]

(In reply to Tom Ritter [:tjr] (ni? for response to sec-[advisories/bounties/ratings/cves]) from comment #2)

Required for blocker uplift which I think we should do...

This'll need an approval request then too.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f16b2746e674

Comment 8

[Simon Giesecke [:sg] [he/him]]

Comment on attachment 9171916 [details]
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=#dom-workers-and-storage

Beta/Release Uplift Approval Request

• User impact if declined: Prerequisite for fixing sec-high bug 1660800 easily
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is marking an IPDL protocol as refcounted, which means that the existing internal refcount is exposed to user code. Manual deallocation is removed, which removes the potential for misuses, without introducing new ones.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Prerequisite for fixing sec-high bug 1660800 easily
• User impact if declined: Exposure to UAF as described in bug 1660800
• Fix Landed on Version: 82
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is marking an IPDL protocol as refcounted, which means that the existing internal refcount is exposed to user code. Manual deallocation is removed, which removes the potential for misuses, without introducing new ones.
• String or UUID changes made by this patch:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171916 [details]
Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=#dom-workers-and-storage

Approved for 81.0b6 and 78.3esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eae025d8914f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/d44bc8b55b6a