1660828 - libffi 3.3 update breaks under clang-11

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[(Away)]

On x86 Linux (and x86 Android) builds:

js/src/ctypes/libffi/src/x86/sysv.S:830:1: error: changed section type for .eh_frame, expected: 0x1

https://searchfox.org/mozilla-central/rev/19c23d725f27d0989e4a60f36d64004cebb39736/js/src/ctypes/libffi/src/x86/sysv.S#830

This error was added in clang-11: https://github.com/llvm/llvm-project/commit/75af9da755721123e62b45cd0bc0c5e688a9722a

If this only happens on 32-bit builds, how come we satisfied #elif defined(HAVE_AS_X86_64_UNWIND_SECTION_TYPE) ?

Comment 1

[(Away)]

Task if needed: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313848324&repo=try&lineNumber=6519

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: Bug 1660828 - move `HAVE_AS_X86_64_UNWIND_SECTION_TYPE` to be x86-64 Unix-specific; r=#build

Somehow we have had it be a general define, but it has not mattered...at
least it won't matter until we upgrade to clang 11, at which point the
compiler will start to complain at us about the codepaths this define
activates.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d809d55636b6
move `HAVE_AS_X86_64_UNWIND_SECTION_TYPE` to be x86-64 Unix-specific; r=firefox-build-system-reviewers,rstewart

Comment 4

[(Away)]

Confirmed the patch fixes the build, thanks Nathan!

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d809d55636b6

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1659906

Comment 7

[Mike Hommey [:glandium]]

Can you request uplift?

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 9171763 [details]
Bug 1660828 - move HAVE_AS_X86_64_UNWIND_SECTION_TYPE to be x86-64 Unix-specific; r=#build

Beta/Release Uplift Approval Request

• User impact if declined: No user impact, but people building with clang 11 will be able to complete their builds.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is purely a build-time fix and its effects are well-understood.
• String changes made/needed: None

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9171763 [details]
Bug 1660828 - move HAVE_AS_X86_64_UNWIND_SECTION_TYPE to be x86-64 Unix-specific; r=#build

approved for 81.0b3

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/842c05c41356