1660887 - Instrument Firefox Desktop User Inactivity Periods for FOG evaluation

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

As I mentioned in bug 1635242 comment#3, we need a little more information about user _in_activity in order to make the best estimate for the lifecycle design (specifically for "baseline" pings).

This bug is about instrumenting FOG with a histogram that is exactly like FOG_EVAL_USER_ACTIVE_S except in inverse, because it'll measure user _in_activity.

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1660887 - Measure user inactivity to evaluate FOG lifecycle triggers r?janerik!

Comment 2

[Chris H-C :chutten]

Attachment: data collection review

Comment 3

[Teon Brooks [:teon]]

Comment on attachment 9173444 [details]
data collection review

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file Histograms.json and the Probe Dictionary and in its definitions file Scalars.yaml and the Probe Dictionary.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Fx85.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

fog.eval.user_inactive_error: Category 1, Technical.
FOG_EVAL_USER_INACTIVE_S: Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :chutten is responsible for renewing or removing the collection before it expires in Fx85.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c74ba13e5d6f
Measure user inactivity to evaluate FOG lifecycle triggers r=janerik

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c74ba13e5d6f

Comment 6

[Chris H-C :chutten]

Comment on attachment 9173439 [details]
Bug 1660887 - Measure user inactivity to evaluate FOG lifecycle triggers r?janerik!

Beta/Release Uplift Approval Request

• User impact if declined: None. The Firefox Telemetry team will have to wait an extra month to get the data necessary to design how Glean pings will work on Firefox Desktop.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This query looks into the number of unexpected situations (I call them errors) and there've been none so far on Nightly: https://sql.telemetry.mozilla.org/queries/74509/source
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173439 [details]
Bug 1660887 - Measure user inactivity to evaluate FOG lifecycle triggers r?janerik!

Thanks for sanity checking the incoming Nightly data first. Approved for 81.0b9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b190fe406188